| Ticket UUID: | e334de21177152f5df419393dbde7d4aeb447885 | |||
| Title: | "sak provided" needs to ignore all the build.tcl's or else they will create ridiculous files in strange places. | |||
| Type: | Bug | Version: | current | |
| Submitter: | anonymous | Created on: | 2018-06-13 15:53:27 | |
| Subsystem: | Build System & Testing | Assigned To: | aku | |
| Priority: | 9 Immediate | Severity: | Severe | |
| Status: | Closed | Last Modified: | 2018-06-19 20:21:32 | |
| Resolution: | Fixed | Closed By: | aku | |
| Closed on: | 2018-06-19 20:21:32 | |||
| Description: |
Summary says it all. | |||
| User Comments: |
aku added on 2018-06-19 20:21:32:
Fixed with merge commit [5b0076422d] bringing in hypnotoad changes, especially a restructuring which hides the sources and build code of his modules from sak and installer. stu added on 2018-06-19 18:19:18: [4bef92af87da4547] aku added on 2018-06-18 21:47:06: Further ref [4bef92af87da4547] hypnotoad added on 2018-06-18 21:30:45: It appears that trunk missed a lot of updates from the hypnotoad branch that clarify to the sak.tcl system which parts of the file system to ignore. I would propose a merge of trunk tag: [c3a46560db6c7860df7989ebaa03ede47ff2d310] With the latest hypnotoad checkin: [e42366acb6804168f3aec267d82379222e1b01f1] hypnotoad added on 2018-06-18 21:10:57: That patch also needs to ignore any source code in a directory named /build that contains a file named build.tcl. All of those files are ingredients to produce the final module file, and may very well contain patterns that will frighten and confuse an automated package indexer.
The concept of the amalgamator for certain modules is to break the implementation up into smaller logical chunks, as well as provide a means to produce the tweaks needed to build repetitive regression tests as well as compile data files into source code snippets.
These modules are rebuilt but running tclsh build/build.tcl
The output is the $module.tcl file as well as the pkgIndex.tcl file and (sometimes) the $module.test file.
The proper patch would be:
if {[file isdirectory $f] && [file tail $f] eq "build"} {continue}
This matches a similar existing exclusion in the sak installer code.
| |||
Attachments:
- patch-sak_tcl [download] added by anonymous on 2018-06-13 15:55:25. [details]