Tcl Library Source Code

Ticket Change Details
Login
Overview

Artifact ID: a389756869145190163cb31c004e0cd5743f0899db418b97dd62f86a7a108755
Ticket: d9be31a488f644839811f7addf0da80f047f1a27
smtp::initialize fails with "<-- 421 4.3.2 Service not available"
User & Date: aku 2018-05-17 19:53:41
Changes

  1. assignee changed to: "aku"
  2. icomment:
    Comments in the code:
    
    https://core.tcl.tk/tcllib/artifact/a4ca98d41fd10afe?ln=592-595
    
    indicate that ports should be matched to servers, i.e. indeed be iterated together.
    
    The increment at
    https://core.tcl.tk/tcllib/artifact/a4ca98d41fd10afe?ln=677
    looks indeed to be much too late, what with the two `continue`s at
    https://core.tcl.tk/tcllib/artifact/a4ca98d41fd10afe?ln=652
    and
    https://core.tcl.tk/tcllib/artifact/a4ca98d41fd10afe?ln=669
    
    Moving the increment just after
    https://core.tcl.tk/tcllib/artifact/a4ca98d41fd10afe?ln=633
    should work
    
    The proposed nested iteration will not match servers and ports as documented. It would try each port with each server, i.e do a cartesian product of both, like a SQL join.
    
    However
    
        foreach server  $options(-servers) $port $options(-ports) { ... } 
    
    might do what we want, if it fills missing elements with the empty string when on of the lists is too short.
    
    That would avoid all the index calculations entirely.
    
  3. login: "aku"
  4. mimetype: "text/x-fossil-wiki"
  5. priority changed to: "7 High"