Artifact
74815fb87ebcc954f25696b108805293bc8a19a4:
Ticket change
[74815fb87e]
- New ticket [561c505d9760b278|561c505d97] <i>WebSocket headers not correctly checked</i>.
by
anonymous
2015-04-16 08:16:12.
D 2015-04-16T08:16:12.574
J assignee nobody
J closer nobody
J cmimetype text/plain
J comment Requests\swere\sbeing\s(incorrectly)\sprocessed\swithout\schecking\r\nwhether\sthey\sinclude\sthe\sUpgrade\sand\sConnect\sheaders.\s\sThe\r\nfollowing\spatch\ssolves\sthe\sissue.\r\n\r\ncommit\s559a6dbc8a2bad39a3363d994237cc92\r\nAuthor:\sAdrián\sMedraño\sCalvo\s<[email protected]>\r\nDate:\s\s\sThu\sApr\s16\s10:10:35\s2015\s+0200\r\n\r\n\s\s\s\s[ws]:\sEnsure\sWebSocket\sheaders\sare\spresent\r\n\r\n\s\s\s\sRequests\swere\s(incorrectly)\sprocessed\swithout\schecking\swhether\r\n\s\s\s\sthey\sinclude\sthe\sUpgrade\sand\sConnect\sheaders.\s\sThe\sfollowing\r\n\s\s\s\spatch\ssolves\sthe\sissue.\r\n\r\ndiff\s--git\sa/src/websocket.tcl\sb/src/websocket.tcl\r\nindex\s6d60537..a9e0624\s100644\r\n---\sa/src/websocket.tcl\r\n+++\sb/src/websocket.tcl\r\n@@\s-431,8\s+431,17\s@@\r\n\s\t\t}\r\n\s\t\tdict\slappend\sres\sprotocols\s{*}$protocols;\r\n\s\t\s\s\s\s}\r\n+\t\s\s\s\sdefault\s{\r\n+\t\t#\sIgnore\sother\sheaders.\r\n+\t\s\s\s\s}\r\n\s\t}\r\n\s\s\s\s\s}\r\n+\s\s\s\sif\s{!$upgrading}\s{\r\n+\tThrowError\s"No\s'Connect'\sheader\swith\s'upgrade'\stoken\sfound"\sHANDSHAKE\sCONNECTION\r\n+\s\s\s\s}\r\n+\s\s\s\sif\s{!$websocket}\s{\r\n+\tThrowError\s"No\s'Upgrade'\sheader\swith\s'websocket'\stoken\sfound"\sHANDSHAKE\sUPGRADE\r\n+\s\s\s\s}\r\n\s\s\s\s\sif\s{![dict\sexists\s$res\sversion]}\s{\r\n\s\tThrowError\s"No\sWebSocket\sversion\sspecified"\sHANDSHAKE\sVERSION\r\n\s\s\s\s\s}
J foundin 1.4
J is_private 0
J login anonymous
J priority 5\sMedium
J private_contact 7e3820ed81064cf9306d34dd9be1633e66f1a08b
J resolution None
J severity Severe
J status Open
J submitter anonymous
J subsystem websocket
J title WebSocket\sheaders\snot\scorrectly\schecked
J type Bug
K 561c505d9760b278249fb814587c1b5b92395dc8
U anonymous
Z ef7f4eb631d698305f27d14061970a26
