Tcl Library Source Code

Artifact [5548bad0c3]
Login

Artifact 5548bad0c3ffda29264869cc20b326b4822ce404:

Ticket change [5548bad0c3] - New ticket [5d23e45b0ec5a81e|5d23e45b0e] <i>Websocket keys should not be wrapped</i>. by anonymous 2014-09-22 15:38:26.
D 2014-09-22T15:38:26.923
J assignee nobody
J closer nobody
J cmimetype text/plain
J comment ::base64::encode\sdefaults\sto\sline\sfolding.\sMake\ssure\sWebSocket\skeys\sare\snot\sfolded.\r\n\r\n--------\s>8\s--------\r\n\r\ncommit\s4ed0887b50c262df6b1477d92b950d0be16943d6\r\nAuthor:\sAdrián\sMedraño\sCalvo\s<[email protected]>\r\nDate:\s\s\sMon\sSep\s22\s17:35:00\s2014\s+0200\r\n\r\n\s\s\s\s[ws]:\sMake\ssure\snot\sto\swrap\sthe\sWebSocket\skey\r\n\r\ndiff\s--git\sa/src/websocket.tcl\sb/src/websocket.tcl\r\nindex\s6d60537..a9e0624\s100644\r\n---\sa/src/websocket.tcl\r\n+++\sb/src/websocket.tcl\r\n@@\s-1434,7\s+1434,7\s@@\sproc\s::websocket::open\s{\surl\shandler\sargs\s}\s{\r\n\s\s\s\s\sfor\s{\sset\si\s0\s}\s{\s$i\s<\s4\s}\s{\sincr\si\s}\s{\r\n\s\s\s\s\s\s\s\s\sappend\sOPEN(nonce)\s[binary\sformat\sIu\s[expr\s{int(rand()*4294967296)}]]\r\n\s\s\s\s\s}\r\n-\s\s\s\sset\sOPEN(nonce)\s[::base64::encode\s$OPEN(nonce)]\r\n+\s\s\s\sset\sOPEN(nonce)\s[::base64::encode\s-maxlen\s0\s$OPEN(nonce)]\r\n\s\s\s\s\sset\sHDR(Sec-WebSocket-Key)\s$OPEN(nonce)\r\n\s\s\s\s\sset\sHDR(Sec-WebSocket-Protocol)\s[join\s$protos\s",\s"]\r\n\s\s\s\s\sset\sHDR(Sec-WebSocket-Version)\s$WS(ws_version)\r\n@@\s-1652,7\s+1652,7\s@@\sproc\s::websocket::configure\s{\ssock\sargs\s}\s{\r\n\sproc\s::websocket::sec-websocket-accept\s{\skey\s}\s{\r\n\s\s\s\s\svariable\sWS\r\n\s\s\s\s\sset\ssec\s${key}$WS(ws_magic)\r\n-\s\s\s\sreturn\s[::base64::encode\s[sha1::sha1\s-bin\s$sec]]\r\n+\s\s\s\sreturn\s[::base64::encode\s-maxlen\s0\s[sha1::sha1\s-bin\s$sec]]\r\n\s}\r\n\s\r\n\s#\s::websocket::SplitCommaSeparated\s--\sExtract\selements\sfrom\scomma-separated\sheaders
J is_private 0
J login anonymous
J priority 5\sMedium
J private_contact 139b1eaf5ce8aad0f86e2ad385566019220aa1cf
J resolution None
J severity Minor
J status Open
J submitter anonymous
J subsystem websocket
J title Websocket\skeys\sshould\snot\sbe\swrapped
J type Bug
K 5d23e45b0ec5a81e67aa1f492339a31e4c8b4ada
U anonymous
Z 355b04db721c24717e8cf3566ba6f106