Tcl Source Code

Ticket Change Details
Login
Overview

Artifact ID: 862ee003f4c03d04601bb8de92e090ad9f19c5e5
Ticket: 1889431fffffffffffffffffffffffffffffffff
quell compilation warnings
User & Date: dkf 2016-08-23 14:01:30
Changes

  1. assignee changed to: "aku"
  2. closer changed to: "nobody"
  3. comment changed to:
    Hello,
    
    I'm working on making our code (which uses Tcl extensively) compile cleanly with most GCC warnings enabled and some of the issues reported are coming from tcl/tk headers.
    
    The attached patch fixes the issues encountered from including tcl.h, which includes shadow warnings for 'index' declared on many functions and checking HAVE_DECLSPEC's value without it being set.  The patch just quells the shadow but changing the function signatures to not name the argument index (maybe call it idx) would also work.
    
    The warning flags being cleaned up are as follows:
    
    -W -Wall -Wundef -Wfloat-equal -Wshadow -Wunreachable-code -Winline -Wconversion
    
    Cheers!
    Sean
    
  4. login: "dkf"
  5. mimetype: "text/plain"
  6. severity changed to: "Minor"
  7. subsystem changed to: "53. Configuration and Build Tools"