Tcl Source Code

View Ticket
Login
Ticket UUID: 1889431
Title: quell compilation warnings
Type: Patch Version: None
Submitter: brlcad Created on: 2008-02-08 06:37:14
Subsystem: 53. Configuration and Build Tools Assigned To: aku
Priority: 4 Severity: Minor
Status: Open Last Modified: 2016-08-23 14:01:30
Resolution: None Closed By: nobody
    Closed on:
Description:
Hello,

I'm working on making our code (which uses Tcl extensively) compile cleanly with most GCC warnings enabled and some of the issues reported are coming from tcl/tk headers.

The attached patch fixes the issues encountered from including tcl.h, which includes shadow warnings for 'index' declared on many functions and checking HAVE_DECLSPEC's value without it being set.  The patch just quells the shadow but changing the function signatures to not name the argument index (maybe call it idx) would also work.

The warning flags being cleaned up are as follows:

-W -Wall -Wundef -Wfloat-equal -Wshadow -Wunreachable-code -Winline -Wconversion

Cheers!
Sean
User Comments: brlcad added on 2008-02-22 04:34:08:
Logged In: YES 
user_id=785737
Originator: YES

It was never a question of what causes the warnings.  I merely provided our list to show which ones we tested and worked on cleaning.  The -Wshadow flag is desirable for other reasons hence the provided (trivial) patch that quells them.

dkf added on 2008-02-08 18:52:01:
Logged In: YES 
user_id=79902
Originator: NO

Don't use -Wshadow

brlcad added on 2008-02-08 13:37:16:

File Added - 265511: quell.patch

Attachments: