Tk Source Code

It looks like recent changes to Mac dialog code are causing assertion failures in the latest [6806933] core-8-6-branch.

Under macOS 10.12.5:

% tk_getSaveFile
2017-06-27 09:07:59.514 wish[61495:8197619] *** Assertion failure in -[NSSavePanel setNameFieldStringValue:], /Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1504.83.101/Nav.subproj/NSSavePanel.m:3396
2017-06-27 09:07:59.518 wish[61495:8197619] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: value != nil'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007fff94fcb2cb __exceptionPreprocess + 171
    1   libobjc.A.dylib                     0x00007fffa9dd648d objc_exception_throw + 48
    2   CoreFoundation                      0x00007fff94fd0042 +[NSException raise:format:arguments:] + 98
    3   Foundation                          0x00007fff96a18c80 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 195
    4   AppKit                              0x00007fff93139148 -[NSSavePanel setNameFieldStringValue:] + 146
    5   libtk8.6.dylib                      0x0000000106d1a851 Tk_GetSaveFileObjCmd + 2365
    6   libtcl8.6.dylib                     0x0000000106dc4e7b TclNRRunCallbacks + 80
    7   libtcl8.6.dylib                     0x0000000106e4c38a Tcl_RecordAndEvalObj + 432
    8   libtcl8.6.dylib                     0x0000000106e4c19c Tcl_RecordAndEval + 60
    9   libtk8.6.dylib                      0x0000000106c87cfb StdinProc + 239
    10  libtcl8.6.dylib                     0x0000000106e582ae Tcl_NotifyChannel + 277
    11  libtcl8.6.dylib                     0x0000000106eb9316 FileHandlerEventProc + 257
    12  libtcl8.6.dylib                     0x0000000106e6fc9a Tcl_ServiceEvent + 147
    13  libtcl8.6.dylib                     0x0000000106e6ff41 Tcl_DoOneEvent + 327
    14  libtk8.6.dylib                      0x0000000106c7a99e Tk_MainLoop + 33
    15  libtk8.6.dylib                      0x0000000106c87913 Tk_MainEx + 1054
    16  wish                                0x0000000106c5f44d main + 47
    17  libdyld.dylib                       0x00007fffaa6bb235 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Abort trap: 6

Commits to trunk and 8-6-branch that address this issue. Thanks for the bug report.

I am baffled how these crashes did not appear when I tested the patch. I've asked Christian to take another look at it.

OK, so what triggered this is [a1d1fbc386e4f253] (giving the link here, easier).

Confirmed.
Works in 15c9e9c05598dd629767db9c3a34219035e1c186 
Fails in a1d1fbc386e4f253db18dc25a67da0312fe44de4

Mac OS X 10.12.5