Tk Source Code

View Ticket
Login
Bounty program for improvements to Tcl and certain Tcl packages.
Tcl 2019 Conference, Houston/TX, US, Nov 4-8
Send your abstracts to tclconference@googlegroups.com
or submit via the online form by Sep 9.
Ticket UUID: 791292
Title: tip 155 implementation
Type: Support Version: None
Submitter: vincentdarley Created on: 2003-08-19 15:20:56
Subsystem: None Assigned To: dkf
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2009-07-29 20:09:23
Resolution: Closed By: vincentdarley
    Closed on: 2003-10-31 09:04:34
Description:
The attached patch makes various changes to the text
widget, amongst which is a first cut at fixing the
long-standing inability of the text widget to interact
correctly with a scrollbar when the text widget
contains very long wrapped lines.

More work is still needed, but this basic patch works
reasonably well for me.

I'd very interested in comments.

(Note: the patch also has a first cut implementation of
a -blockcursor option and a 'replace' subcommand).
User Comments: dkf added on 2009-07-29 20:09:23:

IP - Comment Removed: 130.88.1.31

dkf added on 2008-11-21 21:29:02:

data_type - 212997

vincentdarley added on 2003-10-31 16:04:34:
Logged In: YES 
user_id=32170

Checked in -- thanks!

dkf added on 2003-10-31 04:09:28:
Logged In: YES 
user_id=79902

Do you want to check this in or shall I do it?

vincentdarley added on 2003-10-13 22:27:36:

File Deleted - 63314: 



File Added - 64209: TkText.patch.gz

vincentdarley added on 2003-10-13 22:27:35:
Logged In: YES 
user_id=32170

Final implementation attached.  Lots more 'search' tests, in
particular.

vincentdarley added on 2003-10-03 22:47:31:

File Deleted - 62989:

vincentdarley added on 2003-10-03 22:47:30:

File Added - 63314: TkText.patch.gz

vincentdarley added on 2003-10-03 22:47:28:
Logged In: YES 
user_id=32170

More tests, overhaul of 'search' fixing various '-all' bugs
in particular.  Minor fix to 'replace'.

vincentdarley added on 2003-09-30 21:00:43:

File Deleted - 62588:

vincentdarley added on 2003-09-30 21:00:42:

File Added - 62989: TkText.patch.gz

vincentdarley added on 2003-09-30 21:00:40:
Logged In: YES 
user_id=32170

Further update with some 'search -all' fixes, more tests,
and a better async-line-update implementation.

vincentdarley added on 2003-09-26 16:31:54:

File Deleted - 62517: 



File Added - 62588: TkText.patch.gz

Logged In: YES 
user_id=32170

Fix for embedded windows which need special handling for
smooth scrolling.

vincentdarley added on 2003-09-26 00:03:29:

File Deleted - 62505:

vincentdarley added on 2003-09-26 00:03:28:

File Added - 62517: TkText.patch.gz

vincentdarley added on 2003-09-26 00:03:16:
Logged In: YES 
user_id=32170

Fixed a visual glitch caused by unfortunate overloading of
'-1' exposed by the smooth scrolling code.

vincentdarley added on 2003-09-25 21:41:53:

File Deleted - 62387:

vincentdarley added on 2003-09-25 21:41:52:

File Added - 62505: TkText.patch.gz

Logged In: YES 
user_id=32170

Added some more documentation, made some of the naming
conventions a bit clearer.

vincentdarley added on 2003-09-24 22:31:41:

File Deleted - 62193:

vincentdarley added on 2003-09-24 22:31:35:

File Added - 62387: TkText.patch.gz

vincentdarley added on 2003-09-24 22:31:27:
Logged In: YES 
user_id=32170

This version resolves the last remaining known issue.

vincentdarley added on 2003-09-22 22:08:34:

File Deleted - 61965:

vincentdarley added on 2003-09-22 22:08:32:

File Added - 62193: TkText.patch.gz

vincentdarley added on 2003-09-22 22:08:28:
Logged In: YES 
user_id=32170

Updated for latest version of TIP with full documentation,
and fixes a problem when the height of the widget is less
than the height of a single line.

vincentdarley added on 2003-09-20 00:12:42:

File Deleted - 61847: 



File Added - 61965: TkText.patch.gz

vincentdarley added on 2003-09-20 00:12:41:
Logged In: YES 
user_id=32170

New version with more tests, more docs, a few minor bug fixes.

vincentdarley added on 2003-09-18 21:46:02:

File Deleted - 61751:

vincentdarley added on 2003-09-18 21:39:47:

File Added - 61847: TkText.patch.gz

vincentdarley added on 2003-09-18 21:26:04:
Logged In: YES 
user_id=32170

Update for version 1.8 of tip.  Resolves the indices vs
chars annoyance based on more feedback.  TIP is now final, I
would say.

vincentdarley added on 2003-09-17 21:13:44:

File Deleted - 61661: 



File Added - 61751: TkText.patch

vincentdarley added on 2003-09-17 21:13:43:
Logged In: YES 
user_id=32170

Here's a patch which integrates smooth scrolling fully into
the code, so that mousewheel, scan-drag etc are all smooth...

This implements version 1.7 of the TIP, based on extensive
feedback.

vincentdarley added on 2003-09-17 01:12:29:

File Deleted - 61553: 



File Added - 61661: TkText.patch

vincentdarley added on 2003-09-17 01:12:28:
Logged In: YES 
user_id=32170

Yes another patch, providing a more sensible implementation
of '-count' which also covers the 'how tall does my text
widget need to be' question.

vincentdarley added on 2003-09-15 17:33:02:

File Deleted - 61363: 



File Added - 61553: TkText.patch

vincentdarley added on 2003-09-15 17:33:01:
Logged In: YES 
user_id=32170

Updated patch fixing one known visual glitch with scrolling.
 Also fixes a privately reported bug with 'search -all'. 

No known bugs now.

vincentdarley added on 2003-09-12 21:50:59:

File Deleted - 61347:

vincentdarley added on 2003-09-12 21:50:58:

File Added - 61363: TkText.patch

Logged In: YES 
user_id=32170

Updated to version 1.4 of TIP.

vincentdarley added on 2003-09-12 18:19:22:

File Deleted - 61270: 



File Added - 61347: TkText.patch

vincentdarley added on 2003-09-12 18:19:21:
Logged In: YES 
user_id=32170

New patch for version 1.3 of TIP.  In particular, +/-
displaylines is now much better.

vincentdarley added on 2003-09-11 23:31:53:

File Deleted - 61250: 



File Added - 61270: TkText.patch

vincentdarley added on 2003-09-11 19:47:48:

File Deleted - 60694:

vincentdarley added on 2003-09-11 19:47:46:

File Added - 61250: TkText.patch

vincentdarley added on 2003-09-11 19:47:38:
Logged In: YES 
user_id=32170

New patch for version 1.2 of TIP with smooth scrolling.
Removed the TIP from this patch, since that's now on the TIP
archive.

vincentdarley added on 2003-09-05 18:49:48:

File Deleted - 60692: 



File Added - 60694: TkText.patch

Logged In: YES 
user_id=32170

Fixed 'replace' when 'undo' is off.

vincentdarley added on 2003-09-05 18:36:00:

File Deleted - 60590: 



File Added - 60692: TkText.patch

Logged In: YES 
user_id=32170

Overall patch cleanup, fixing of tests, adding new tests, etc.

vincentdarley added on 2003-09-05 18:34:55:

File Deleted - 60589: 



File Added - 60691: 155.tip

vincentdarley added on 2003-09-04 20:46:18:

File Deleted - 60570: 



File Added - 60590: TkText.patch

vincentdarley added on 2003-09-04 20:46:17:
Logged In: YES 
user_id=32170

Uploaded relatively final, complete patch.

vincentdarley added on 2003-09-04 20:45:01:

File Deleted - 60489:

vincentdarley added on 2003-09-04 20:45:00:

File Added - 60589: 155.tip

vincentdarley added on 2003-09-04 16:40:39:

File Deleted - 60487: 



File Added - 60570: TkText.patch

Logged In: YES 
user_id=32170

Newer patch, fixes the 'deleting lots of text with lots of
tags is very slow' bug in Tk 8.x.

vincentdarley added on 2003-09-03 20:44:15:

File Added - 60489: 155.tip

vincentdarley added on 2003-09-03 20:44:11:
Logged In: YES 
user_id=32170

Added draft TIP.

vincentdarley added on 2003-09-03 20:26:35:

File Deleted - 60419: 



File Added - 60487: TkText.patch

Logged In: YES 
user_id=32170

Added more tests, documentation, and fixed a number of small
bugs which showed up.

vincentdarley added on 2003-09-03 00:20:31:

File Deleted - 59294:

vincentdarley added on 2003-09-03 00:20:30:

File Deleted - 59482: 



File Added - 60419: TkText.patch

Logged In: YES 
user_id=32170

Another update, with some more tests, and adds the +/- N
displaylines capability to index manipulation.

vincentdarley added on 2003-08-22 18:41:00:

File Added - 59482: TkTextScroll.patch

vincentdarley added on 2003-08-22 18:40:59:
Logged In: YES 
user_id=32170

One more version. Now implements 'replace' correctly, and
the 'displayline(start|end)' index offset code.  Only
remaining piece is a good 'blockcursor' implementation.

vincentdarley added on 2003-08-21 22:18:54:

File Added - 59386: TkTextScroll.patch

Logged In: YES 
user_id=32170

One more version.  Cleans up the patch, provides better
documentation, and improves the efficiency of updates
triggered by small insertions or deletions.

vincentdarley added on 2003-08-21 03:09:22:

File Added - 59313: TkTextScroll.patch

Logged In: YES 
user_id=32170

Yet another update.  Fixes embedded windows problem and 
one more test (related to scroll-bar update frequency).

vincentdarley added on 2003-08-21 00:41:09:

File Deleted - 59263:

vincentdarley added on 2003-08-21 00:41:08:

File Added - 59294: TkTextScroll.patch

vincentdarley added on 2003-08-21 00:41:07:
Logged In: YES 
user_id=32170

Updated patch for greater efficiency, using the
configure-mask capabilities of Tk.

There is one outstanding bug wrt embedded windows not being
unmapped.  I'm looking into it.

vincentdarley added on 2003-08-20 21:20:45:

File Added - 59263: TkTextScroll.patch

vincentdarley added on 2003-08-20 21:20:44:
Logged In: YES 
user_id=32170

Yet another update; now down to just 3 new test failures,
all of which appear actually to be correct results with the
new code.

vincentdarley added on 2003-08-20 18:56:53:

File Added - 59243: TkTextScroll.patch

Logged In: YES 
user_id=32170

Updated patch, now passes all except a few tests (some of
whose results should probably be different now).

vincentdarley added on 2003-08-19 22:20:57:

File Added - 59150: tkTextScroll.diff

Attachments: