Tk Source Code

In application Scidb I have three tabs in main notebook: Information, Database, and Board. Sometimes it happens that when switching from Database tab to Information tab (via mouse click in tab bar) the Information tab is flickering a short time, and then the Database tab is still visible, although the Information tab is displayed as selected in tab bar.

I found out that sometimes via a geometry request the function NotebookPlaceSlaves() (ttkNotebook.c) will be triggered after function SelectTab() has been entered, but before the current index is set to new tab index, and this function will change back to previous tab (current index = Database tab), because this function is not regarding the index of the active tab, in this case it's the newly selected Information tab.

Okay, trusting you in that.

Merged to core-8-6-branch and trunk.

Thanks!

I don't have a script, it happens in Scidb, a huge application with a very complex widget hierarchy. But it is reproducible: install Scidb from repository, start scidb-beta, select Board tab, then select Database tab, then select Information tab, and it will show the Database tab, although the Information tab handle is shown as selected. I'm working with the patch since two weeks, and it works properly, everything is okay.

The fix (the second one) looks OK to me.

Any script you can show, that would demonstrate the bug perhaps? It's probably a bit difficult because this is likely to be triggered by a race condition.

The first fix [168b6715] did not work properly, so I have reverted the changes.

The second fix [168b6715] now is setting currentIndex before NotebookPlaceSlave() will be invoked, due to my analysis this can have only one side effect: an interveaning call of NotebookPlaceSlaves() will change to the correct tab.

A fix has been committed with [168b6715]. Now the active index will be regarded when processing the geometry request.