Tk Source Code

Hi,

After some discussions on #tcl, I started adding the BLT busy command to Tk as tk::busy. I've tried to convert as much as possible to the Tcl Object interface. Before writing a TIP I would like to get some feedback as this is my first try at writing a Tk core command.

Attached the patch created with command

  % cvs -q diff -wuN > busypatch.txt

based on the head revision.

Also attached a summary of the commands.

What's left to be done:

- man page
- tests for Tk test suite
- Mac version?

Jos.

IP - Comment Removed: 130.88.1.31

data_type - 212997

File Deleted - 281868:

File Deleted - 292958:

File Deleted - 294323:

File Added - 294351: tkBusy.c

File Added: tkBusy.c

File Added - 294350: busypatch-06.txt

File Added: busypatch-06.txt

File Added - 294325: busy.n

File Added: busy.n

File Added - 294324: busy.test

File Added: busy.test

File Added - 294323: busypatch-05.txt

Renamed command to 'tk busy', Updated patch, man page and test suite.
File Added: busypatch-05.txt

File Added - 292958: busy.test

File Added: busy.test

File Added - 292957: busy.n

File Added: busy.n

File Added - 292956: busypatch-04.txt

File Added: busypatch-04.txt

File Added - 283178: busy.test

Logged In: YES 
user_id=370749
Originator: YES

Tests for the tk::bsy command.
File Added: busy.test

File Added - 283177: busy.n

Logged In: YES 
user_id=370749
Originator: YES

Updated man page.
File Added: busy.n

File Added - 283176: busypatch-03.txt

Logged In: YES 
user_id=370749
Originator: YES

A updated patch.
File Added: busypatch-03.txt

File Added - 283153: busy.n

Logged In: YES 
user_id=370749
Originator: YES

A man page for the tk::busy command. The grab man page might get a 'see also' pointing to tk::busy:

.SH "SEE ALSO"
busy(n)


Jos.
File Added: busy.n

File Added - 282744: busypatch-02.txt

Logged In: YES 
user_id=370749
Originator: YES

Updated the patch with suggested changes.
File Added: busypatch-02.txt

Logged In: YES 
user_id=79902
Originator: NO

Initial comments:

I see a number of sections of code where it's "#ifdef WIN32"-heavy. It'd be better to factor those pieces out into platform-specific implementations of Tkp functions (e.g. TkpMakeTransparentWindow for parts of the guts of MakeTransparentWindowExist).

You can remove the debugging #ifdefs :-)

Why is the busy hash table (in tk.h/tkInt.h) part way through the structure? That just causes gratuitous ABI incompatibility. Put it at the end of the structure instead.

File Added - 281868: busycmd.txt

Logged In: YES 
user_id=370749
Originator: YES

File Added: busycmd.txt

File Added - 281867: busypatch.txt