Tk Source Code

View Ticket
Login
Bounty program for improvements to Tcl and certain Tcl packages.
Tcl 2019 Conference, Houston/TX, US, Nov 4-8
Send your abstracts to tclconference@googlegroups.com
or submit via the online form by Sep 9.
Ticket UUID: 1997907
Title: tk::busy command
Type: Support Version: None
Submitter: decosterjos Created on: 2008-06-19 14:32:49
Subsystem: None Assigned To: dkf
Priority: 9 Immediate Severity:
Status: Closed Last Modified: 2009-07-29 20:06:14
Resolution: Closed By: dkf
    Closed on: 2008-10-18 14:23:04
Description:
Hi,

After some discussions on #tcl, I started adding the BLT busy command to Tk as tk::busy. I've tried to convert as much as possible to the Tcl Object interface. Before writing a TIP I would like to get some feedback as this is my first try at writing a Tk core command.

Attached the patch created with command

  % cvs -q diff -wuN > busypatch.txt

based on the head revision.

Also attached a summary of the commands.

What's left to be done:

- man page
- tests for Tk test suite
- Mac version?

Jos.
User Comments: dkf added on 2009-07-29 20:06:14:

IP - Comment Removed: 130.88.1.31

dkf added on 2008-12-05 04:35:59:

data_type - 212997

decosterjos added on 2008-09-22 19:56:24:

File Deleted - 281868:

decosterjos added on 2008-09-22 19:56:23:

File Deleted - 292958:

decosterjos added on 2008-09-22 19:56:22:

File Deleted - 294323:

decosterjos added on 2008-09-22 19:55:55:

File Added - 294351: tkBusy.c

File Added: tkBusy.c

decosterjos added on 2008-09-22 19:55:23:

File Added - 294350: busypatch-06.txt

File Added: busypatch-06.txt

decosterjos added on 2008-09-22 15:24:56:

File Added - 294325: busy.n

File Added: busy.n

decosterjos added on 2008-09-22 15:24:08:

File Added - 294324: busy.test

File Added: busy.test

decosterjos added on 2008-09-22 15:23:37:

File Added - 294323: busypatch-05.txt

Renamed command to 'tk busy', Updated patch, man page and test suite.
File Added: busypatch-05.txt

decosterjos added on 2008-09-11 14:09:24:

File Added - 292958: busy.test

File Added: busy.test

decosterjos added on 2008-09-11 14:08:55:

File Added - 292957: busy.n

File Added: busy.n

decosterjos added on 2008-09-11 14:08:26:

File Added - 292956: busypatch-04.txt

File Added: busypatch-04.txt

decosterjos added on 2008-06-30 19:04:27:

File Added - 283178: busy.test

Logged In: YES 
user_id=370749
Originator: YES

Tests for the tk::bsy command.
File Added: busy.test

decosterjos added on 2008-06-30 19:03:49:

File Added - 283177: busy.n

Logged In: YES 
user_id=370749
Originator: YES

Updated man page.
File Added: busy.n

decosterjos added on 2008-06-30 19:03:17:

File Added - 283176: busypatch-03.txt

Logged In: YES 
user_id=370749
Originator: YES

A updated patch.
File Added: busypatch-03.txt

decosterjos added on 2008-06-30 15:13:26:

File Added - 283153: busy.n

Logged In: YES 
user_id=370749
Originator: YES

A man page for the tk::busy command. The grab man page might get a 'see also' pointing to tk::busy:

.SH "SEE ALSO"
busy(n)


Jos.
File Added: busy.n

decosterjos added on 2008-06-26 14:19:22:

File Added - 282744: busypatch-02.txt

Logged In: YES 
user_id=370749
Originator: YES

Updated the patch with suggested changes.
File Added: busypatch-02.txt

dkf added on 2008-06-19 22:05:03:
Logged In: YES 
user_id=79902
Originator: NO

Initial comments:

I see a number of sections of code where it's "#ifdef WIN32"-heavy. It'd be better to factor those pieces out into platform-specific implementations of Tkp functions (e.g. TkpMakeTransparentWindow for parts of the guts of MakeTransparentWindowExist).

You can remove the debugging #ifdefs :-)

Why is the busy hash table (in tk.h/tkInt.h) part way through the structure? That just causes gratuitous ABI incompatibility. Put it at the end of the structure instead.

decosterjos added on 2008-06-19 21:33:51:

File Added - 281868: busycmd.txt

Logged In: YES 
user_id=370749
Originator: YES

File Added: busycmd.txt

decosterjos added on 2008-06-19 21:32:49:

File Added - 281867: busypatch.txt

Attachments: