Tk Source Code

A flat sashrelief is common for panedwindow, when it
separate two widgets with sunken relief.
In this configuration, the proxy window is not well
visible, since it uses the same sashrelief option.
Using a harcoded raised relief, like for the
borderwidth of 2 pixels, appears to be a better
altenative (function DisplayProxyWindow()).

TIP #437 was accepted today through voting of the TCT.

Jan merged the implementation to both core-8-5-branch and trunk.

Closing this ticket now. Thanks to all!

Added implementation of -proxyborderwidth option to the branch tip-437

All three options proposed by the TIP are now implemented, with tests and documentation.

Review requested, thanks.

Added implementation of -proxybackground option to the branch tip-437

The branch hosting the development of the requested features is now renamed from 'bug-1247115fff' to 'tip-437'

TIP #437 created.

Sorry. Got snowed under with work.

Dear Francois,

sorry, TIP is just frustrating nearly all the time.

I hope we get progress here.

I will write to Donal if he just did not mention it.

Thank you,
Harald

No progress was made on the TIP process for two months now. Not even a draft of the TIP was issued. And I'm not even talking about the vote process. All this is so damn slow.

If there is zero interest for this (which is just fine for me), let's just close the present ticket as WONT FIX and throw my corresponding implementation in branch bug-1247115fff to the trash.

Found. Renaming branches is difficult from the command line but easy from fossil ui.

The TIP has been sent to the TIP editor but not yet assigned a number.

In the meantime, see branch  bug-1247115fff

Great. How?

- fossil branch has no "rename" subcommand.

- fossil rename renames files, not branches.

- a recent (2 months ago) thread ( http://lists.fossil-scm.org:8080/pipermail/fossil-users/2015-May/021132.html ) states that such a branch rename command should be added in fossil

- an older thread provides a way by manipulating tags, but what is said there about possible consequences is scary: https://www.mail-archive.com/[email protected]/msg13916.html

Sorry, I definitely miss a simple and clear example.

Fossil permits branch renaming.

I now have a reference implementation for -proxyrelief in my local fossil repository.

Usage is to name such implementation branch "tip-xxx", where xxx is the TIP number.
AFAIK fossil does not allow renaming of branches.

Therefore I'm now waiting for your TIP number before sharing the implementation in a pushed branch.

OK. About how to proceed, you can start reading here:

http://www.tcl.tk/cgi-bin/tct/tip

My english is far from perfect, and I don't know how to proceed, but I'll try to do it. In the meantime, if someone else want to do it...
So let's go with -proxyrelief and -proxybackground, which gives all the control the the user.
Thanks for your support.

I'm willing to do the implementation, if and only if you run the TIP and voting process with the TCT. Do you want this feature enough to run this process?

We can also add -proxybackground to be complete, and allow giving a darker background to the proxy on light / grey background.

OK, I see now, thanks.

I'm wondering whether your proposal ("using a harcoded raised relief" instead of using the same relief for the proxy as specified for the sash)would need a TIP or not.

An alternative could be to add a -proxyrelief option and let the user specify what is wanted. But that would definitely need a TIP (in my understanding regarding when a TIP is needed, at least).

Not sure:
  - what is the correct way to fix this
  - if this fix would need a TIP or not

Core members, advice please?

Hi,

Personnaly, I don't use red and blue background.
So just reusing your code with more common borderwidth and colors:

  package require Tk
  catch {destroy .pw .f1 .f2}
  panedwindow .pw -orient vertical -sashrelief flat
  frame .f1 -background white -height 100 -relief sunken -borderwidth 2
  frame .f2 -height 100 -relief sunken -borderwidth 2
  .pw add .f1 .f2
  pack .pw -expand 1 -fill both
  .pw proxy place 1 140
  .pw conf -opaqueresize false  ; # now move the proxy sash with button-1

Sorry but I fail to see why using the same relief for the proxy as configured for the sash is a problem.

The following script shows two sunken panes separated by a flat sash. Also the script places a proxy (with flat relief since the proxy inherits the relief of the sash, as you noted in function DisplayProxyWindow). Everything seems correctly visible for me.


  package require Tk
  catch {destroy .pw .f1 .f2}
  panedwindow .pw -orient vertical -sashrelief flat
  frame .f1 -background red -height 100 -relief sunken -borderwidth 5
  frame .f2 -background blue -height 100 -relief sunken -borderwidth 5
  .pw add .f1 .f2
  pack .pw -expand 1 -fill both
  .pw proxy place 1 140
  .pw conf -opaqueresize false ; # now move the proxy sash with button-1


This needs a script demonstrating the issue.