Tk Source Code

Ticket Change Details
Login
Overview

Artifact ID: 9063e7881f86057a5cd3661f7ec46db67a6d4221
Ticket: cac46925857f9928049828bc2e1552aa3842d2bd
Revised [text]: assertion failed in tkTextDisp.c:7191
User & Date: fvogel 2017-08-20 16:35:42
Changes

  1. icomment:
    The following patch prevents the assertion from triggering in the situation I can otherwise make it trigger repeatably in my application:
    
    <verbatim>
    Index: generic/tkText.c
    ==================================================================
    --- generic/tkText.c
    +++ generic/tkText.c
    @@ -1865,11 +1865,11 @@
                    break;
                case 'y':
                    if (strncmp("-ypixels", option, length) == 0) {
                        int from, to;
    
    -                   if (update) {
    +                   if (update && (TkTextIndexCompare(&indexFrom, &indexTo) != 0)) {
                            from = TkTextIndexGetLineNumber(&indexFrom, textPtr);
                            to = TkTextIndexGetLineNumber(&indexTo, textPtr);
                            UpdateLineMetrics(textPtr, from, to);
                        }
                        from = TkTextIndexYPixels(textPtr, &indexFrom);
    </verbatim>
    
    Is this correct, or is there a better fix?
    
  2. login: "fvogel"
  3. mimetype: "text/x-fossil-wiki"