Tk Source Code

Check-in [831734f0]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Increase the size of the event ring to 45 on macOS, because the new code demands a bigger ring.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | mojave-cleanup
Files: files | file ages | folders
SHA3-256: 831734f0f31bea8a6c51b86c27862348e0fe006c6bf5e67de494e784b57bc227
User & Date: culler 2018-10-26 15:04:30
Original Comment: Increase the siae of the event ring to 45 on macOS, because the new code demands a bigger ring.
References
2018-10-28
19:07
Increase the size of the ring buffer (in bind.test) according to the change made in [831734f0] check-in: 5e69a6d6 user: fvogel tags: mojave-cleanup
2018-10-26
15:16 Ticket [796462af] Images don't display in "a simple interface for displaying images" status still Open with 4 other changes artifact: 35b06599 user: marc_culler
Context
2018-10-26
18:15
Addressed a few deprecations in the Fullscreen implementation. check-in: b37fcc65 user: culler tags: mojave-cleanup
15:04
Increase the size of the event ring to 45 on macOS, because the new code demands a bigger ring. check-in: 831734f0 user: culler tags: mojave-cleanup
03:11
Added some debugging tools. check-in: 4256c644 user: culler tags: mojave-cleanup
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to generic/tkBind.c.

71
72
73
74
75
76
77











78


79
80
81
82
83
84
85
 * down (and auto-repeating). There may be as many as 3 auto-repeat events
 * after each mouse button press or release (see the first large comment block
 * within Tk_BindEvent for more on this), for a total of 20 events to cover
 * the three button presses and two intervening releases. If you reduce
 * EVENT_BUFFER_SIZE too much, shift multi-clicks will be lost.
 */












#define EVENT_BUFFER_SIZE 30


typedef struct Tk_BindingTable_ {
    XEvent eventRing[EVENT_BUFFER_SIZE];
				/* Circular queue of recent events (higher
				 * indices are for more recent events). */
    Detail detailRing[EVENT_BUFFER_SIZE];
				/* "Detail" information (keySym, button,
				 * Tk_Uid, or 0) for each entry in







>
>
>
>
>
>
>
>
>
>
>
|
>
>







71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
 * down (and auto-repeating). There may be as many as 3 auto-repeat events
 * after each mouse button press or release (see the first large comment block
 * within Tk_BindEvent for more on this), for a total of 20 events to cover
 * the three button presses and two intervening releases. If you reduce
 * EVENT_BUFFER_SIZE too much, shift multi-clicks will be lost.
 */

/*
 * NOTE: The changes which were needed to make Tk work on OSX 10.14 (Mojave)
 * also demand that the event ring be a bit bigger.  It might be wise to
 * augment the current double-click pattern matching by adding a new
 * DoubleClick modifier bit which could be set based on the clickCount of the
 * Apple NSEvent object.
 */

#ifndef TK_MAC_OSX
  #define EVENT_BUFFER_SIZE 45
#else
  #define EVENT_BUFFER_SIZE 30
#endif

typedef struct Tk_BindingTable_ {
    XEvent eventRing[EVENT_BUFFER_SIZE];
				/* Circular queue of recent events (higher
				 * indices are for more recent events). */
    Detail detailRing[EVENT_BUFFER_SIZE];
				/* "Detail" information (keySym, button,
				 * Tk_Uid, or 0) for each entry in