Tk Source Code

Check-in [168b6715]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Bugfix [4966cad4d4]: Now function NotebookPlaceSlaves() in ttkNotebook.c will regard the active index.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | bug-4966cad4d4
Files: files | file ages | folders
SHA1: 168b671518b7008a348763215b644bec12708f4f
User & Date: gcramer 2017-07-21 14:05:07
References
2017-07-23
17:11 Ticket [4966cad4] status still Open with 3 other changes artifact: c9a8f28e user: gcramer
2017-07-21
14:07 Ticket [4966cad4]: 3 changes artifact: dac62388 user: gcramer
Context
2017-07-23
17:06
I reverted the previous fix, because it doesn't work. The current solution is to set currentIndex before NotebookPlaceSlave() will be called, due to my analysis this can have only one side effect: an interveaning call of NotebookPlaceSlaves() will change to the correct tab. check-in: 96333b9a user: gcramer tags: bug-4966cad4d4
2017-07-21
14:05
Bugfix [4966cad4d4]: Now function NotebookPlaceSlaves() in ttkNotebook.c will regard the active index. check-in: 168b6715 user: gcramer tags: bug-4966cad4d4
2017-07-03
08:36
merge-mark check-in: f7910148 user: jan.nijtmans tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to generic/ttk/ttkNotebook.c.

591
592
593
594
595
596
597


598

599

600
601
602
603
604
605
606
 * 	Geometry manager hook.
 */
static void NotebookPlaceSlaves(void *recordPtr)
{
    Notebook *nb = recordPtr;
    int currentIndex = nb->notebook.currentIndex;
    if (currentIndex >= 0) {


	NotebookDoLayout(nb);

	NotebookPlaceSlave(nb, currentIndex);

    }
}

/*
 * SelectTab(nb, index) --
 * 	Change the currently-selected tab.
 */







>
>

>
|
>







591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
 * 	Geometry manager hook.
 */
static void NotebookPlaceSlaves(void *recordPtr)
{
    Notebook *nb = recordPtr;
    int currentIndex = nb->notebook.currentIndex;
    if (currentIndex >= 0) {
	int activeIndex = nb->notebook.activeIndex;
	int index = (activeIndex >= 0) ? activeIndex : currentIndex;
	NotebookDoLayout(nb);
	if (index >= 0) {
	    NotebookPlaceSlave(nb, index);
	}
    }
}

/*
 * SelectTab(nb, index) --
 * 	Change the currently-selected tab.
 */