Tk Source Code

Artifact [a7271b9e]
Login

Artifact a7271b9eff761ef491688741f084bf8534074d0c0fd0ad38529f6191732dc1c0:

Ticket change [a7271b9e] - Ticket [1821174f] RenderBadPicture (invalid Picture parameter) status still Open with 3 other changes by jenglish 2018-01-17 21:58:32.
D 2018-01-17T21:58:32.482
J icomment >\sAlso,\scould\sJoe\sEnglish\splease\sreview\sand\sprovide\shis\sopinion\son\sthe\spatch?\s\r\n\r\nThe\spatch\sis\snot\snecessary.\sUnder\snormal\scircumstances\sTk\sdoes\sthe\sright\sthing\r\ninside\sTk_CreateErrorHandler()\s...\sTk_DeleteErrorHandler()\sblocks,\sthere\sis\r\n\sno\sneed\sto\scall\sXSync(),\sand\sin\sfact\sdoing\sso\sis\slikely\sto\shurt\sperformance.\s\r\n(Also:\smy\smistake,\schw\sis\scorrect,\sthis\slogic\sis\spart\sof\sTk,\snot\sXlib.)\r\n\r\nThe\scause\sof\sthe\sproblem\sis\sa\sbug\sin\sTk's\sshutdown\ssequence.\r\nFrom\s2007-10-28\scomment,\sthe\sroot\scause:\r\n\r\n>\sis\sbecause\sDeleteWindowsExitProc\ssets\stsdPtr->displayList\sto\sNULL\r\n>\sbefore\scalling\sTkCloseDisplay()\son\seach\smember\sof\sthe\slist.\r\n\r\nThe\scorrect\sfix\sprobably\sinvolves\snulling\sout\stsdPtr->displayList\s*after*\s\r\ncalling\sTkCloseDisplay()\sinstead\sof\sbefore;\sIIRC\sthe\sonly\sreason\sI\sdidn't\sdo\s\r\nthat\sin\s2007\sis\sthat\sthe\simplications\sof\smaking\sthat\schange\swere\sunclear\s\r\n(Tk's\sshutdown\ssequence\sis\srather\scomplicated.)
J login jenglish
J mimetype text/plain
K 1821174fffffffffffffffffffffffffffffffff
U jenglish
Z 27e73f44d94f420046d85b7479f64dac