Tk Source Code

Artifact [77151d19]
Login

Artifact 77151d190a296d7b5a71210bb2d5010df78be90d11da979239816c71de82f087:

Ticket change [77151d19] - Ticket [1821174f] RenderBadPicture (invalid Picture parameter) status still Open with 3 other changes by chw 2018-01-17 23:03:22.
D 2018-01-17T23:03:22.752
J icomment To\sbe\smore\sprecise,\slet's\stake\sXFreeColors()\sused\sby\sTkpFreeColor()\senclosed\sin\sTk_(Create|Delete)ErrorHandler().\sThe\simplementation\sin\s2001\sX11R6\sis\r\n\r\n\s\sint\r\n\s\sXFreeColors(dpy,\scmap,\spixels,\snpixels,\splanes)\r\n\s\sregister\sDisplay\s*dpy;\r\n\s\sColormap\scmap;\r\n\s\sunsigned\slong\s*pixels;\s/*\sLISTofCARD32\s*/\r\n\s\sint\snpixels;\r\n\s\sunsigned\slong\splanes;\s/*\sCARD32\s*/\r\n\s\s{\r\n\s\s\s\sregister\sxFreeColorsReq\s*req;\r\n\s\s\s\sregister\slong\snbytes;\r\n\r\n\s\s\s\sLockDisplay(dpy);\r\n\s\s\s\sGetReq(FreeColors,\sreq);\r\n\s\s\s\sreq->cmap\s=\scmap;\r\n\s\s\s\sreq->planeMask\s=\splanes;\r\n\r\n\s\s\s\s/*\son\sthe\sVAX,\seach\spixel\sis\sa\s32-bit\s(unsigned)\sinteger\s*/\r\n\s\s\s\sreq->length\s+=\snpixels;\r\n\r\n\s\s\s\snbytes\s=\snpixels\s<<\s2;\s\s\s\s\s\s\s\s\s\s\s\s\s\s/*\swatch\sout\sfor\smacros...\s*/\r\n\s\s\s\sData32\s(dpy,\s(long\s*)\spixels,\snbytes);\r\n\s\s\s\sUnlockDisplay(dpy);\r\n\s\s\s\sSyncHandle();\r\n\s\s\s\sreturn\s1;\r\n\s\s}\r\n\r\nIt\smakes\sand\squeues\sa\sprotocol\srequest,\sand\sfinallydoes\sSyncHandle().\r\nNormally,\sSyncHandle()\sis\sa\snoop\sexcept\sshould\swe\sdebug\susing\r\nXSynchronize(...,\sTrue);\r\n\r\nMy\s(possibly\swrong)\sanalysis\sin\sthis\scase\sis:\sTk_(Create|Delete)ErrorHandler()\r\nis\ssome\skind\sof\splacebo\sexcept\sthe\swish\sis\srun\swith\s-sync\swhich\sturns\sthe\r\nSyncHandle()\sstuff\son.
J login chw
J mimetype text/plain
K 1821174fffffffffffffffffffffffffffffffff
U chw
Z 7cddbc3db91bc1dd5f747fb41a8a9e26