Tcl Library Source Code

View Ticket
Login
Ticket UUID: e72cf5e815088248c923ed045372e4464f3e09a7
Title: Extended autoproxy to works with twapi for https (configurable)
Type: RFE Version: trunk
Submitter: oehhar Created on: 2017-11-10 14:08:49
Subsystem: http :: autoproxy Assigned To: aku
Priority: 8 Severity: Minor
Status: Closed Last Modified: 2018-05-07 17:07:34
Resolution: Accepted Closed By: oehhar
    Closed on: 2018-04-17 16:17:07
Description:

Twapi is helpful to be used for https on Windows instead the TLS package for update reasons (twapi gets updated with the operating system, with TLS (on windows), the program author must care to update openssl if required).

For instance, it does not work with autoproxy. Wiki page for some details: http://wiki.tcl.tk/https

It is examined in TWAPI and here, to find out:

  • if this is possible
  • what must be changed in twapi and autoproxy

Here is the twapi ticket: https://sourceforge.net/p/twapi/bugs/162/

User Comments: aku added on 2018-05-07 17:07:34:
Integrated with trunk now.

apnadkarni added on 2018-05-05 04:46:27:
Tested on Win 10 with twapi with no failures.

aku added on 2018-05-01 18:04:34:
Fix pushed. Works for me now.

Please retest in a twapi environment.

aku added on 2018-05-01 17:58:31:
I believe I know.

The last test to make a successful configuration change is 1.2.4.1, setting tls_package to twapi.

And for two, the `packageReset` procedure does not reset the new tls_package information.

Thus it leaks to the 2.0.0 test. And as the 2.x tests do not configure the package for themselves they all think to use twapi.

That works of course works in an environment which has twapi.

Fixing now ...

aku added on 2018-05-01 17:55:32:
Pushed a fix for the multiple -setup clauses.

This did not fix the linux test failures.

Investigation continues

aku added on 2018-05-01 17:52:15:
I see no difference between the tests autoproxy 2.0.0 and 2.0.1, except the title and constraints. Setup, body, and cleanup are identical. Ditto for 2.1.0 and 2.1.1

I further see multiple -setup declarations in these tests.
I do not believe that both will be run, only the second.

I wonder if that may be the issue, i.e. packageReset missing.

aku added on 2018-05-01 17:45:11:
Re-opened. Still to merge. Currently investigating Linux testsuite failures.
Notes:

- Tweaked the doc setup to have the custom tls note part of the second, and not before

- Added Tcl 8.5 requirement to have `in`/`ni` operators.

oehhar added on 2018-04-23 07:36:22:

For the records, the patch was tested with success by Harald and Alexandru (see the clt thread).

Thus I favor to merge it.

Thank you, Harald


oehhar added on 2018-04-17 16:17:07:

Fixed by Ashok in branch "autoproxy-twapi-support".

Thank you, ticket closed, Harald