| Ticket UUID: | e368ba6683926255f5f109c478e91c63fbce32f9 | |||
| Title: | ThreadSafeLocalTime(): check if localtime_r() encountered error | |||
| Type: | Patch | Version: | 8.6.13 | |
| Submitter: | chrstphrchvz | Created on: | 2023-09-20 22:37:25 | |
| Subsystem: | 06. Time Measurement | Assigned To: | nobody | |
| Priority: | 5 Medium | Severity: | Minor | |
| Status: | Closed | Last Modified: | 2024-02-16 10:38:42 | |
| Resolution: | Fixed | Closed By: | chrstphrchvz | |
| Closed on: | 2024-02-16 10:38:42 | |||
| Description: |
In response to bug [1237907], ThreadSafeLocalTime() checks whether localtime() encountered an error (e.g. EOVERFLOW) by checking if the return value is NULL: [96beb107b193]. The same check is needed for localtime_r() as well. See attached patch. | |||
| User Comments: |
chrstphrchvz added on 2024-02-16 10:38:42:
If there is no interest in having non-regression tests for this (similar to those in the other attached patch) then I will not reopen this. oehhar added on 2024-02-07 17:37:21: Merged by commit [c94812e9a9] oehhar added on 2024-02-07 17:36:36: As the patch was merged, it might be closed, no? chrstphrchvz added on 2023-09-21 00:16:24: I would like to propose non-regression tests for this: see localtime-tests.diff. However I have not completely verified their portability, and maybe their formatting can be improved. | |||
Home
Timeline
Branches
Tags
Tickets
Download
Wiki