Tcl Source Code

The following commands cause a segfault on 8.6 and 8.7a0 (Mac OS X 10.10.5):

% set json {{"sub":["demo","amadmin"],"exp":"valid","auth":"http://neil.example.com:8080/openam/json/authenticate"}}
{"sub":["demo","amadmin"],"exp":"valid","auth":"http://neil.example.com:8080/openam/json/authenticate"}
% set out [open /tmp/test.json wb]
file6
% zlib push deflate $out
file6
% puts $out $json
% chan configure $out -dictionary
rlwrap: warning: tclsh8.7 crashed, killed by SIGSEGV.

Thanks!

Would be good to fix for 8.6.6.

potential patch attached.  I thought it might be possible to read the compression dictionary generated by zlib after pushing some data through, but looking at the TIP and zlib manual it's clear that's not intended.

The patch introduces some tests, makes getting an unconfigured -dictionary work and adds some text from http://www.zlib.net/manual.html to the docs, making it cleared how the option works.

Making the inflate case work correctly required removing the lines at [1] - I think this is correct but dkf might know if there's a reason to do otherwise.

[1]:  http://core.tcl.tk/tcl/artifact/3354467036e27f0b?ln=3623-3624