Tcl Source Code

The attached patch represents
work in progress toward
separating the search path
for encodings from the search
path for the script library 
(init.tcl). 

It is not yet in
acceptable shape to commit, but it
should apply and run, so 
testing is encouraged.

Logged In: YES 
user_id=32170

Please see bug 1077005 introduced by this patch.

Logged In: YES 
user_id=80530

committed for Tcl 8.5a2.

File Deleted - 110649: 



File Added - 110719: 976520.patch

Logged In: YES 
user_id=80530

updated patch takes care
of some code cleanup.

File Deleted - 110605:

File Added - 110649: 976520.patch

Logged In: YES 
user_id=80530

updated patch corrects a Windows
compile error, and inlines
the initScript.

File Deleted - 110236: 



File Added - 110605: 976520.patch

Logged In: YES 
user_id=80530

updated patch does that rename, 
fixes some remaining unixInit.test
issues, and reformats as a unidiff.

Other than a little code cleanup,
this should be ready now.

Logged In: YES 
user_id=80530

Yes, that sounds like a good idea.

Logged In: YES 
user_id=79902

Should that be TclpGetEncodingNameFromEnvironment(), to
emphasize that this is not returning an encoding but a
string that names what encoding would be preferred?

File Deleted - 110016: 



File Added - 110236: 976520.patch

Logged In: YES 
user_id=80530

Updated patch include a new routine
TclpGetEncodingFromEnvironment()
so that it is possible to learn from
Tcl what it thinks the [encoding system]
should be, even when a missing *.enc
file, or an incomplete encoding search
patch won't let the [encoding system] be
properly initialized.

File Deleted - 109888: 



File Added - 110016: 976520.patch

Logged In: YES 
user_id=80530

updated patch corrects some
Windows bugs (thanks, kbk),
and adds some more progress, too.

Logged In: YES 
user_id=80530


Having multiple directories seems
better to me, allowing
apps or users to extend the
encodings available without
having to copy/reproduce all
of them that come installed with Tcl.

The patch taking shape here provides
routines Tcl(Get|Set)EncodingSearchPath
that can easily support the command,
or be made public to support C apps.

Logged In: YES 
user_id=72656

FWIW, I was going to TIP it as 'encoding directory', as in a
single directory.  'searchpath' (or just 'path') implies
multiple directories.  Did we want to allow for that?

Logged In: YES 
user_id=80530

thanks for testing on unix.
The unixInit-2.4 failure is a known
glitch;  it reflects a weakness in
the test more than any real problem.

The most effective way to fix that
will actually be when the
[encoding searchpath] (or whatever
we decide to call it) sub-command
becomes available.  That TIP should
be coming along soon after 8.5a2 release.

Logged In: YES 
user_id=148712

Confirming that the patch sets the correct encoding for ./tclsh.
But I now get a failure of unixInit-2.4

File Deleted - 109879: 



File Added - 109888: 976520.patch

Logged In: YES 
user_id=80530


D'OH!  That patch would not 
even compile on WIndows.

I think this one will, but need
someone to test for sure.

File Deleted - 109748:

File Added - 109879: 976520.patch

Logged In: YES 
user_id=80530


more progress.

standalone ./tclsh
should get the right
[encoding system] now.

File Deleted - 109645: 



File Added - 109748: 976520.patch

Logged In: YES 
user_id=80530

update to HEAD again.

File Deleted - 107736: 



File Added - 109645: 976520.patch

Logged In: YES 
user_id=80530

Update to HEAD

File Deleted - 97961: 



File Added - 107736: 976520.patch

Logged In: YES 
user_id=80530

Update to HEAD

File Deleted - 93267: 



File Added - 97961: 976520.patch

Logged In: YES 
user_id=80530

Update to HEAD.

File Deleted - 93265:

File Added - 93267: 976520.patch

File Added - 93265: 976520.patch

Logged In: YES 
user_id=99768

Uploaded a revised patch that fixes a couple of compilation
errors on Windows

File Deleted - 92537: 



File Added - 93262: 976520.patch

Logged In: YES 
user_id=80530

updated again to resolve
conflicts with the HEAD

File Deleted - 92298: 



File Added - 92537: 976520.patch

Logged In: YES 
user_id=80530

updated to resolve conflicts
with the HEAD.

Logged In: YES 
user_id=202636

Tested this patch with Win98 MSVC 6. The patched version 
raised no new test suite failures.

File Deleted - 92288: 



File Added - 92298: 976520.patch

Logged In: YES 
user_id=80530

updated again for testing

File Deleted - 91897: 



File Added - 92288: 976520.patch

Logged In: YES 
user_id=80530

updated to HEAD

File Deleted - 91693: 



File Added - 91897: 976520.patch

Logged In: YES 
user_id=80530

just another update.

File Added - 91693: 976520.patch

Logged In: YES 
user_id=99768

Uploaded revised patch that corrects a few compilation problems
on vc++

Logged In: YES 
user_id=80530

That last comment isn't
quite correct; but getting
closer.

File Deleted - 91586: 



File Added - 91691: 976520.patch

Logged In: YES 
user_id=80530


Updated patch reforms
Tcl_FindExecutable so
that it need not do encoding
corrections for itself.  It no
longer needs the 
TclInitSubsystems call itself,
but it is left in place until
the proper alternative initialization
triggers are identified.

File Deleted - 91536: 



File Added - 91586: 976520.patch

Logged In: YES 
user_id=80530

updated patch to resolve conflicts

File Deleted - 91422: 



File Added - 91536: 976520.patch

Logged In: YES 
user_id=80530

Revised patch is considerably
more ambitious in re-writing
encoding initialization and
other startup logic.  Please test.

File Deleted - 91415: 



File Added - 91422: 976520.patch

Logged In: YES 
user_id=80530

Revised patch incorporates
kbk's fixes and only adds
existing directories to the
default encoding search path.

File Added - 91415: esp-kbk.patch

Logged In: YES 
user_id=99768

Attaching a revised patch that silences several compilation
warnings in VC++.  No new test failures in either VC++ or
mingw with --enable-threads or without.

File Added - 91323: esp.patch