| Ticket UUID: | 966053 | |||
| Title: | stop repeated findExecutable searches | |||
| Type: | Patch | Version: | None | |
| Submitter: | dgp | Created on: | 2004-06-03 19:47:41 | |
| Subsystem: | 10. Objects | Assigned To: | dgp | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2004-06-19 03:38:08 | |
| Resolution: | Accepted | Closed By: | dgp | |
| Closed on: | 2004-06-18 20:38:08 | |||
| Description: |
Patch includes two improvements. 1) In TclpFindExecutable() note that successful searches have been saved and returned forever. Only one search permitted. On the other hand, failed searches have been invited to come back and spend time and effort failing over and over again. The changes to tclUnixFile.c make it so that a failure result is also saved and returned forever without the expense of repeating the search operations. 2) In tclEncoding.c, I've renamed TclFindEncodings to FindEncodings to match its status as a file static routine. That makes it clearer that the only caller is Tcl_FindExecutable, and that caller has already called TclpFindExecutable, so there's no need for FindEncodings to do it again. (The source of some of the repetition addressed in 1) ). Without the need to call TpFE, FindEncodings also needed no argument, so it was removed. | |||
| User Comments: |
dgp added on 2004-06-19 03:38:08:
Logged In: YES user_id=80530 applied to HEAD. dgp added on 2004-06-04 03:28:26: File Deleted - 89431: File Added - 89438: 966053.patch Logged In: YES user_id=80530 ok, just a test command that needed an update. Here's the revised patch. dgp added on 2004-06-04 03:06:00: Logged In: YES user_id=80530 hhmmpph, well that patch makes 5 tests fail. Investigating... dgp added on 2004-06-04 02:47:42: File Added - 89431: fexec.path | |||
Attachments:
- 966053.patch [download] added by dgp on 2004-06-04 03:28:26. [details]