Tcl Source Code

View Ticket
Login
Ticket UUID: 954014
Title: changes to tcl8.4.6/tests directory
Type: Bug Version: obsolete: 8.4.6
Submitter: aotto1968 Created on: 2004-05-14 14:51:32
Subsystem: 34. tcltest Package Assigned To: dgp
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2004-05-17 22:38:28
Resolution: Works For Me Closed By: dgp
    Closed on: 2004-05-17 15:38:28
Description:
Hi, 
 
  this are the collected changes to the tcl8.4.6 
  tests directory. mostley it fixes notset -myaddr 
  cases for "socket -server ..." tests plus an 
  directory bug belonging to "tcltest::testsDirectory" 
 
mfg 
 
  aotto
User Comments: dgp added on 2004-05-17 22:38:28:
Logged In: YES 
user_id=80530

more to the point, why
is the -setup script of
test tcltest-9.1 not taking
care of the issue?

aotto1968 added on 2004-05-16 15:42:53:
Logged In: YES 
user_id=1030114

Hi, 
 
  local directory is the default for "-testdir" 
 
man tcltest 
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>  
 
 testsDirectory ?directory? 
              Same as [configure -testdir ?directory?]. 
 
 
 -testdir directory 
              Sets the directory searched by [runAllTests] 
for test files and subdirectories.  Default value is 
[workingDirectory]. 
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< 
 
this only works if localdirectory is testdirectory 
 
 
mfg 
 
  aotto

dgp added on 2004-05-15 00:33:07:
Logged In: YES 
user_id=80530

more to the point, why
is the -setup script of
test tcltest-9.1 not taking
care of the issue?

nobody added on 2004-05-14 23:43:01:
Logged In: NO 

take me through it step by
step and tell me how
testDirectory got its bogus
value?

aotto1968 added on 2004-05-14 23:38:28:
Logged In: YES 
user_id=1030114

Hi, 
 
this should help :) 
 
  1. testsDirectory=.../build_shared 
  2. build_shared has no all.tcl 
 
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> 
dev1usr@linux02:~/Project/TclBase.build/src/tcl8.4.6/
build_shared> ./tcltest ../tests/tcltest.test  
testsDirectory=/home/Project/TclBase.build/src/tcl8.4.6/
build_shared 
 
==== tcltest-9.1 -file a*.tcl FAILED 
==== Contents of test case: 
 
    slave msg [file join [testsDirectory] all.tcl] -file 
a*.test 
    list [regexp assocd\.test $msg] 
 
---- Result was: 
0 
---- Result should have been (exact matching): 
1 
==== tcltest-9.1 FAILED 
 
tcltest.test:   Total   124     Passed  119     Skipped 4       
Failed  1 
Number of tests skipped for each constraint: 
        3       nonRoot 
        1       singleTestInterp 
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< 
 
 
mfg 
 
  aotto

dgp added on 2004-05-14 22:55:39:
Logged In: YES 
user_id=80530


this patch has many changes
relevant to many Categories.
For example, proposed changes
to "socket.test" should be
filed under "27. Channel Types"
so the [socket] maintainer can
review them. Etc.

Looking just at the changes to
the tcltest.test, this is really a
symptom of poor use of the
test suite.  The all.tcl file takes
care of initializing [configure -testdir]
to the correct value.  This should work:

make test TESTFLAGS="-file tcltest.test"

or alternatively

tclsh ../path/to/all.tcl -file tcltest.test

direct evaluation of the *.test files is
not the recommended procedure.

That said, I find that in fact,

./tcltest ../tests/tcltest.test

Works For Me

aotto1968 added on 2004-05-14 21:51:32:

File Added - 87160: tests.patch

Attachments: