Tcl Source Code

View Ticket
Login
Ticket UUID: 928506
Title: BUILD_tcl
Type: Bug Version: obsolete: 8.4.6
Submitter: tauvan Created on: 2004-04-02 20:10:44
Subsystem: 47. Bytecode Compiler Assigned To: msofer
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2004-04-07 06:15:24
Resolution: Invalid Closed By: msofer
    Closed on: 2004-04-06 23:15:24
Description:
Me agian.

#-------------------------------
tclCompile.h:

Original Code:
#ifndef _TCLINT
#include "tclInt.h"
#endif /* _TCLINT */

#ifdef BUILD_tcl
# undef TCL_STORAGE_CLASS
# define TCL_STORAGE_CLASS DLLEXPORT
#endif

Proposed:
#include "tclInt.h"

see "tracking defines"

#-------------------------------
tclRegexp.h:
Removed:
#ifdef BUILD_tcl
# undef TCL_STORAGE_CLASS
# define TCL_STORAGE_CLASS DLLEXPORT
#endif

#-------------------------------
tclInt.h:

Original Code:
#define _TCLINT ....... to
/*
 * The following procedures allow namespaces to be customized 
to
changed to:
#define _TCLINT

#include "tcl.h"
/*
 * Common include files needed by most of the Tcl source files 
are
 * included here, so that system-dependent personalizations for 
the
 * include files only have to be made in once place.  This results
 * in a few extra includes, but greater modularity.  The order of
 * the three groups of #includes is important.For example, 
stdio.h
 * is needed by tcl.h, and the _ANSI_ARGS_ declaration in tcl.h 
is
 * needed by stdlib.h in some configurations.
 */

#include <ctype.h>
#include <limits.h>
#include <stdlib.h>
#include <string.h>

#undef TCL_STORAGE_CLASS

#ifdef USE_TCL_STUBS
#   define TCL_STORAGE_CLASS
#else
#   define TCL_STORAGE_CLASS DLLIMPORT
#endif

/*
 * The following procedures allow namespaces to be customized 
to

Logic:
the above header and attached "tcl.h"

#-------------------------------
tcl.h:

the top part consolidates almost all "compat" issues in one
location.

I had a problem of <limits.h> seeing "limits.h" in compat instead 
of
system's <limits.h> ... and with others
define <????> to ??????
might need 
#ifndef
#define SOME_HEADER ?????


According to Makefile.in
# On unix we want to use the normal malloc/free 
implementation, so we
# specifically set the USE_TCLALLOC flag.
-DUSE_TCLALLOC=0

only #ifdef MAC_TCL sets USE_TCLALLOC

so added #else sets -DUSE_TCLALLOC=0 and makes
Makefile.in condition for all files not just tclAlloc.c
since once you start compile it's not defined anyway
except when MAC_TCL is requested

call this "insurance" I guess.

removed: (made standard include for all files @ top)
#ifndef BUFSIZ
#   include <stdio.h>
#endif

the "#if !defined(NO_STDARG)" section:
this code should be in the actual <stdarg.h>
but was used to stop complier warnings

the "#ifdef BUILD_tcl"
again removed (previous sumitted "fixes")
not ever defined

ifdef NO_LIMITS_H changed to ifndef HAVE_LIMITS_H
HAVE_LIMITS_H gets defined twice during makefile process

the "#include <defines.h>" should be removed. It's a file created 
from
configure's "confdef.h" file
User Comments: msofer added on 2004-04-07 06:15:24:
Logged In: YES 
user_id=148712

OK, closing it.

tauvan added on 2004-04-06 23:55:54:
Logged In: YES 
user_id=1011552

Hi msofer
Can we can this report now that I seem to be
somewhat catching on to this bug reporting?
I'll try to break it up. Plus it looks like if it was
canned or closed it would remove from the tracker list.
Any suggestions?
Thanks;
Steven... tauvan

tauvan added on 2004-04-03 03:29:39:
Logged In: YES 
user_id=1011552

My appologies

BUILD_tcl

is in windows definitions so no changes to tclRegexp.h

Got to be more carefull!!!!

tauvan added on 2004-04-03 03:10:44:

File Added - 82339: tcl.h

Attachments: