| Ticket UUID: | 926312 | |||
| Title: | Small socket read/write optimization | |||
| Type: | Patch | Version: | None | |
| Submitter: | stwo | Created on: | 2004-03-30 22:25:13 | |
| Subsystem: | 25. Channel System | Assigned To: | andreas_kupries | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2004-07-17 01:40:20 | |
| Resolution: | Wont Fix | Closed By: | andreas_kupries | |
| Closed on: | 2004-07-16 18:40:20 | |||
| Description: |
Perform test for TCP_ASYNC_CONNECT before calling WaitForConnect. Only call WaitForConnect if necessary. Remove variable 'state'. A small optimization which removes a function call overhead for read/write operations on sockets (once the socket is connected). Also uses one less variable - this variable wan't really needed in the first place. It should be faster, but a quick measurement shows no noticeable improvement. | |||
| User Comments: |
andreas_kupries added on 2004-07-17 01:40:20:
Logged In: YES user_id=75003 I would not try to outguess the compiler and opt for clean implementation, .i.e. as the code currently is. As proposed it becomes more diffiicult to maintain as changes in the function may have to be reflected to the call-sites as well for the code to stay correct. The patch does not mention that stuff from within WaitForConnect is now duplicated at the places calling WFC. stwo added on 2004-03-31 05:25:13: File Added - 81999: patch-unix_tclUnixChan_c | |||
Attachments:
- patch-unix_tclUnixChan_c [download] added by stwo on 2004-03-31 05:25:13. [details]