Tcl Source Code

When examining generic/tclIOUtil.c, I see a number of
references to things relating to Windows only. Would it
be possible to hive these things off behind a
TclpThingy interface?

At the same time, why is TclpNativeToNormalized defined
in that file at all?  That's a function that I'd expect
to be done exclusively by the platform-specific parts
of the core (for all that it is more work that way.) 
Perhaps we've actually got an error in the splitting of
functionality between functions if we need that much
common code in that function?

I make all these points because keeping different
platform-specific bits of the core separated from the
generic core makes for much cleaner code overall;
#ifdef-fery is often best characterised as an
obfuscation technique rather than a high-quality
programming paradigm...

Logged In: YES 
user_id=32170

Updated patch for latest cvs HEAD changes, and applied.

Logged In: YES 
user_id=80530

also tests ok on Mac OS X

File Added - 103501: 925620.patch

Logged In: YES 
user_id=80530

revised patch tests ok on 
Linux/Alpha and Solaris

now to review the code...

Logged In: YES 
user_id=32170

p.s. patch needs testing on Unix.  Works fine on Windows.

File Added - 103352: fsGeneric.diff

Logged In: YES 
user_id=32170

Attaching a proposed patch to remove #ifdef's and move the
code to the platform directories.

Logged In: YES 
user_id=32170

I agree that we would be better with more platform specific
separation, and less #ifdef'ing.  I'd certainly support any
efforts to clean things up.