Tcl Source Code

View Ticket
Login
Ticket UUID: 918320
Title: tests filename-10.(9,22) fail
Type: Bug Version: obsolete: 8.5a1
Submitter: dgp Created on: 2004-03-17 21:30:10
Subsystem: 36. Pathname Management Assigned To: vincentdarley
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2004-03-30 17:10:30
Resolution: Fixed Closed By: vincentdarley
    Closed on: 2004-03-30 10:10:30
Description:
On Unix systems:

==== filename-10.9 Tcl_TranslateFileName FAILED
==== Contents of test case:

    global env
    set temp $env(HOME)
    set env(HOME) "/home/test/"
    testsetplatform unix
    set result [list [catch {testtranslatefilename ~}
msg] $msg]
    set env(HOME) $temp
    set result

---- Result was:
0 /home/test/
---- Result should have been (exact matching):
0 /home/test
==== filename-10.9 FAILED


==== filename-10.22 Tcl_TranslateFileName FAILED
==== Contents of test case:

    testsetplatform windows
    list [catch {testtranslatefilename foo//bar} msg] $msg

---- Result was:
0 {foo\\bar}
---- Result should have been (exact matching):
0 {foo\bar}
==== filename-10.22 FAILED


This may be a consequence of excising
the Mac code?
User Comments: vincentdarley added on 2004-03-30 17:10:30:
Logged In: YES 
user_id=32170

Fixed.

dgp added on 2004-03-30 04:44:49:
Logged In: YES 
user_id=80530

cleaner is better.  Is it on the way?

vincentdarley added on 2004-03-30 01:17:03:
Logged In: YES 
user_id=32170

That looks good -- I'm actually working on a slightly
different fix which removes the 'equal' variable in favour
of a few goto's -- it actually looks a bit cleaner, but has
the same effect.

I'm happy with either fix, though.

dgp added on 2004-03-30 01:12:10:

File Added - 81783: 918320.patch

Logged In: YES 
user_id=80530


here's the patch that fixes things.

dgp added on 2004-03-30 00:34:33:
Logged In: YES 
user_id=80530

more precisely, reverting
tclPathObj.c to revision 1.24
restores the tests to passing.

tclPathObj.c 1.24 -> 1.25
caused the tests to fail.

dgp added on 2004-03-30 00:25:59:
Logged In: YES 
user_id=80530

these tests pass before the
Mac OS Classic platform
removal, and fail afterwards.

vincentdarley added on 2004-03-28 01:52:05:
Logged In: YES 
user_id=32170

Can you isolate which change in cvs lead to this failure?

Attachments: