Ticket UUID: | 910174 | |||
Title: | registry test english constraint is American. | |||
Type: | Patch | Version: | None | |
Submitter: | patthoyts | Created on: | 2004-03-04 23:43:02 | |
Subsystem: | 32. registry Package | Assigned To: | kennykb | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2004-03-05 22:55:46 | |
Resolution: | Accepted | Closed By: | kennykb | |
Closed on: | 2004-03-05 15:55:46 | |||
Description: |
The registry test package has an 'english' constraint that is set only by US english locale. Here in the UK we think our english is more english than yours of course :) Modifying the constraint to permit UK english shows up only one additional failure under Win98 which is actually an NT specific error message dependency. This patch changes the constraint to a string match instead of string equal. But I'm uncertain that it should perhaps be checking the codepage as well? | |||
User Comments: |
kennykb added on 2004-03-05 22:55:46:
Logged In: YES user_id=99768 I would think that the patch should work even in a hypothetical English-speaking locale that uses another code page, since the Windows error message is transliterated from system encoding to UTF-8. Hence, it looks good as it is. Committed. patthoyts added on 2004-03-05 06:43:03: File Added - 78989: reg98.patch |
Attachments:
- reg98.patch [download] added by patthoyts on 2004-03-05 06:43:03. [details]