Tcl Source Code

I have an example file (591 bytes) where inflation using a channel transform generates a file which is 3096 bytes short of the actual file it was generated from by deflation. Using direct in-memory inflation OTOH is ok, i.e. reconstructs the input correctly (size, and sha256sum). I have not tried to use a stream object.

Example file and test script will be attached.

Output from the example run

  hephaistos:(529) ~/Play/CoreSources/B > tclsh example.tcl 
  ./example.direct:    458752
  ./example.transform: 455656
  Transform under by 3096, vs direct

Followup: Ticket [f70ce1feadf55c2f0fd142bdc20fbdcae5698495].

I confirm that commit [96e1e0251b] fixes the ticket:

hephaistos:(510) ~/Play/CoreSources/B/tcl > tclsh ../example.tcl 
../example.direct:    458752
../example.transform: 458752
Match

... And `make test` passes.

Check-in [96e1e0251b] fixes this, but...

The whole handling around ZlibTransformInput is very strange:

- ZlibTransformInput reads an input buffer for inflate in single bytes (where it can do that in larger chunks), so the internal cycle (e.g. callback execution) repeated toooooo many times;

- ResultGenerate/ResultCopy doing to many copy operations (ResultGenerate could decode to next (required) part of decompression buffer directly so ResultCopy could obtain the buffer without interim copy operations here and there.

- etc;