Tcl Source Code

View Ticket
Login
Ticket UUID: 875055
Title: reimplementation using dicts
Type: Patch Version: None
Submitter: mic42 Created on: 2004-01-11 20:56:49
Subsystem: 30. msgcat Package Assigned To: dgp
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2004-03-31 09:14:25
Resolution: Accepted Closed By: dgp
    Closed on: 2004-03-31 02:14:25
Description:
This matches RFE 811459, internal use of dicts.

It implements the msgcat package using nested
dictionaries instead of one large array.

Also introduced ne, eq in if expressions in places
where string equal was used.

The version number stays at 1.4 as no user visible
changes (other than package require Tcl 8.5) are there.

Michael
User Comments: dgp added on 2004-03-31 09:14:25:
Logged In: YES 
user_id=80530

committed to HEAD to be
part of msgcat 1.4.1 (to be
bundled with Tcl 8.5a2)

dgp added on 2004-03-30 04:50:24:

File Added - 81827: 875055.patch

dgp added on 2004-03-30 04:50:23:
Logged In: YES 
user_id=80530

trying again to attach the patch...

dgp added on 2004-03-27 07:53:02:
Logged In: YES 
user_id=80530


Here's an updated patch that also
makes more use of {expand} and
[source -encoding] .  (If we're gonna
require 8.5, we oughta use it!).  Please
review.

mic42 added on 2004-02-24 17:50:55:
Logged In: YES 
user_id=302287

Ok, here is your ping.

After Bug 871387 has been fixed by dkf some small
improvements for the code are possible. (dict exists now
handles missing subdicts correct, so no need for the
workaround in place).

dgp added on 2004-01-14 07:18:46:
Logged In: YES 
user_id=80530


Thanks for this work.
dkf reports we should expect this
re-implementation to be more
memory efficient.

Might be more improvements
possible pending TIP 163.

Will consider further.  Ping if we get close
to 8.5a1 release without resolution.

mic42 added on 2004-01-12 03:56:49:

File Added - 73076: msgcat.tcl

Attachments: