Ticket UUID: | 871606 | |||
Title: | crash in binary scan - VC++ 5.2 Compiler Bug | |||
Type: | Bug | Version: | obsolete: 8.5a0 | |
Submitter: | vincentdarley | Created on: | 2004-01-06 11:34:58 | |
Subsystem: | 16. Commands A-H | Assigned To: | dkf | |
Priority: | 9 Immediate | Severity: | ||
Status: | Closed | Last Modified: | 2004-01-08 16:18:00 | |
Resolution: | Invalid | Closed By: | vincentdarley | |
Closed on: | 2004-01-07 17:26:34 | |||
Description: |
The latest cvs HEAD crashes with test binary-44.2: binary scan lcTolleH w x set x (this is on Windows XP, release build. Curiously it doesn't crash in the debug build. I'm using VC++ 5.2). About 2 months ago there was no such crash. | |||
User Comments: |
dkf added on 2004-01-08 16:18:00:
Logged In: YES user_id=79902 Just adding a note here for people searching for a solution in the future. If you encounter this problem, the fix is to update your compiler. vincentdarley added on 2004-01-08 00:26:34: Logged In: YES user_id=32170 Found a vc++ update on msdn.com which appears to fix the compiler bug. So, closing this. vincentdarley added on 2004-01-07 23:51:41: File Added - 72583: binary.patch Logged In: YES user_id=32170 Here's a patch to fix the problem (by turning off optimisations for the given function). vincentdarley added on 2004-01-07 17:00:08: Logged In: YES user_id=32170 It appears as if it can't, at least with optimisations on (since debug build works ok). dkf added on 2004-01-07 04:20:18: Logged In: YES user_id=79902 Can't VC++5.2 correctly compile shifts of wide unsigned values?! That's worrying... vincentdarley added on 2004-01-07 00:15:16: Logged In: YES user_id=32170 The bug was introduced in 1.13: http://cvs.sourceforge.net/viewcvs.py/tcl/tcl/generic/tclBinary.c?r1=1.12&r2=1.13 dkf added on 2004-01-06 20:51:30: Logged In: YES user_id=79902 Very strange; I can't see what's failing. (I can't build Tcl on XP, so I'm limited in what tests I can do.) |
Attachments:
- binary.patch [download] added by vincentdarley on 2004-01-07 23:51:41. [details]