Tcl Source Code

All uses of 'panic' in the core should be replaced 
with 'Tcl_Panic' as the comment in tcl.h is clear.

Logged In: YES 
user_id=7549

done.

Logged In: YES 
user_id=7549

Will do.

I'll do the find/replace on Tk and add the compatibility note in 
the Tcl ChangeLog.

Logged In: YES 
user_id=80530

I see.  What has changed is the
meaning of the -DTCL_NO_DEPRECATED
compile option.  Compiling an extension
with that option used to allow panic().
Now it doesn't.  That's quite arguably
a bug fix, so we should be sure this gets
flagged as a ***POTENTIAL INCOMPATIBILITY***
in the ChangeLog and changes file.

Also need to update Tk to the new reality.

Logged In: YES 
user_id=80530


It appears that the Tk HEAD no
longer compiles against the Tcl HEAD
due to this change.  When linking
wish there are errors starting with:

/local/src/tk/unix/libtk8.5.a(tkWindow.o): In function
`TkCreateMainWindow':
tkWindow.c(.text+0xdb4): undefined reference to `panic'
tkWindow.c(.text+0xdb8): undefined reference to `panic'
/local/src/tk/unix/libtk8.5.a(tkWindow.o): In function
`Tk_DestroyWindow':
tkWindow.c(.text+0x1650): undefined reference to `panic'
tkWindow.c(.text+0x1654): undefined reference to `panic'
/local/src/tk/unix/libtk8.5.a(tkWindow.o): In function
`Tk_ConfigureWindow':
tkWindow.c(.text+0x1e28): undefined reference to `panic'

This suggests other extensions may
also have trouble with this change?
Has something public changed without
a TIP?

Logged In: YES 
user_id=7549

committed to HEAD.

Logged In: YES 
user_id=7549

The core is under our control so let's following the rule about 
its deprecation.

File Added - 71394: patch.txt