| Ticket UUID: | 767679 | |||
| Title: | Patches for winFCmd.test | |||
| Type: | Patch | Version: | None | |
| Submitter: | hgiese | Created on: | 2003-07-08 11:12:34 | |
| Subsystem: | 37. File System | Assigned To: | vincentdarley | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2003-07-09 02:38:07 | |
| Resolution: | Fixed | Closed By: | vincentdarley | |
| Closed on: | 2003-07-08 15:10:34 | |||
| Description: |
Hello out there,
on Win98 I have 5 failing test in winFCmd.test (not
Borland related). 3 of them return a different error
code than expected, so I propose to correct our
expectations (see the attached diff file).
The other 2 (6.12 and 6.14) fail like
---- Result was:
1 {D:/devtools/Tcl8430/src/tcl8.4.3/release.vc/tf1 ENOTDIR}
---- Result should have been (exact matching):
1 {tf1 ENOTDIR}
==== winFCmd-6.12 FAILED
Actually they do well, they just return the complete
path (on Win98). The patch simply reduces the full path
via [file tail ...] and all is well.
Oh yes, I added one line of output showing which drive
was considered to be a CD-ROM (or the absence of such).
This might be useful if any of the cd-related tests
fail (it would have been useful for me to know that I:
was considered a CD-ROM - being the first network drive
instead). This one line doesn't cost a whole lot and
might come in handy.
Best regards
Helmut Giese
| |||
| User Comments: |
vincentdarley added on 2003-07-09 02:38:07:
Logged In: YES user_id=32170 Don't worry I didn't renumber existing tests, just the ones added in this patch (which were things like 11.7.1a) dgp added on 2003-07-09 02:33:05: Logged In: YES user_id=80530 "renumbering" of tests is usually a bad idea. It is good to be able to sensibly ask whether test foo-1.23 passed on all releases from Tcl X to Tcl Y. If the identifier of the test changes, that's hard to check. vincentdarley added on 2003-07-08 22:10:34: Logged In: YES user_id=32170 Fixed the tests. Didn't add the 'line of output' since that isn't done by any of Tcl's test suite, and renumbered the tests to avoid letter numbering. hgiese added on 2003-07-08 18:12:34: File Added - 55239: winFCmd_test.diff | |||
Attachments:
- winFCmd_test.diff [download] added by hgiese on 2003-07-08 18:12:34. [details]