Ticket UUID: | 760768 | |||
Title: | Please patch cmdAH.test | |||
Type: | Patch | Version: | None | |
Submitter: | hgiese | Created on: | 2003-06-25 20:56:27 | |
Subsystem: | 16. Commands A-H | Assigned To: | dkf | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2003-07-04 20:19:21 | |
Resolution: | Fixed | Closed By: | dkf | |
Closed on: | 2003-07-04 13:19:21 | |||
Description: |
Hi there, being on Win98 I find it a bit annoying to always have 2 to 3 tests fail because they do not consider this platform's quirks - so to say. The issue is: On non-NT Windows a file's time stamp cannot be to second precise (1 bit is missing), so every time stamp is reduced to even seconds. Now, if you have a test which introduces a delay of one second to see if file time changed, this will fail if the file time is expected to be odd. The changes in the diff file amount to the following: - A little proc which waits up the start of even second, and which is called in all 3 tests involved here (24.2, 24.8, 24-9). - 24.2: I also moved the calls to [clock second] behind the calls to [close] - close can be an expensive opreation, and the new order makes it more probable, that the two will get the same value. - 24.8, 24.9: I changed the delay from 1100 to 2100. With these patches all tests pass. I hope, that the small additional delay introduced will be acceptable to you. Best regards Helmut Giese | |||
User Comments: |
dkf added on 2003-07-04 20:19:21:
Logged In: YES user_id=79902 Really should work out a constraint for when the temporary directory is on a FAT filesystem, but we'll keep going with what we've got. hgiese added on 2003-06-26 03:56:27: File Added - 54118: cmdah.diff |
Attachments:
- cmdah.diff [download] added by hgiese on 2003-06-26 03:56:27. [details]