Tcl Source Code

generic/tclDate.c

1. Shouldn't this file be using ckalloc/ckrealloc? 
2. The following variables are allocated and are 
never freed: 

int *TclDates; 
YYSTYPE *TclDatev; 

-----

It appears that we can override the use of 
malloc/realloc by defining the YYEXPAND 
preprocessor macro and having it call a function 
which does ckalloc/ckrealloc instead.

As for the leak, I think since the only memory that 
is allocated by this file is the two static variables 
above, a finalization routine is in order.  This 
should be a fairly trivial fix.

I have attached a preliminary fix for these two 
issues (this is not a patch, it's just some code to 
cut and paste into tclDate.c/tclGetDate.y).

I'm willing to learn yacc to assist if necessary.

As a "next gen" solution to this problem, I 
suggested to dkf that we parse the dates using Tcl 
code that is evaluated when necessary (since yacc 
appears to be rather wild).

Logged In: YES 
user_id=99768

Original poster confirms that the memory leak is resolved.

Logged In: YES 
user_id=113501

I already have some code that will fix these problems.  
Does anybody have a test case I can use to test it with 
(something that forces it to call malloc/realloc)?
Also, what version of yacc is required and what is the 
proper invocation of the command to process 
tclGetDate.y ?

Logged In: YES 
user_id=72656

No finalization is necessary because those two are statics, 
and I don't think anyone has ever changed that behavior.  The 
point is that this is all yacc, and thus we have to work with 
what yacc gives us.  It may be necessary to change the 
YYEXPAND, but I don't know of any problems that have 
arisen from this.  The "leak" is a red herring because that is a 
never-used code path.

File Added - 50173: datefix.c