Tcl Source Code

View Ticket
Login
Ticket UUID: 681793
Title: io-43*: move [open |cat] into setup
Type: Bug Version: obsolete: 8.5a0
Submitter: dgp Created on: 2003-02-06 17:22:02
Subsystem: 25. Channel System Assigned To: andreas_kupries
Priority: 2 Severity:
Status: Closed Last Modified: 2006-03-17 02:12:50
Resolution: Fixed Closed By: andreas_kupries
    Closed on: 2006-03-16 19:12:50
Description:
Pipelines to "cat" are [open]ed to prepare
for tests io-43.*  The tests are properly
constrained with unixExecs, but it would
be better to move the [open] into -setup
scripts so the [open] is only attempted
on the constrained systems.

minor detail, but I noticed it so thought
I'd log it while I saw it.
User Comments: andreas_kupries added on 2006-03-17 02:12:50:
Logged In: YES 
user_id=75003

Committed the attached files to HEAD and 8.4 branch head, resp.

andreas_kupries added on 2006-03-17 02:11:22:

File Added - 171173: 85.iotest.udiff

andreas_kupries added on 2006-03-17 02:10:57:

File Added - 171172: 84.iotest.udiff

andreas_kupries added on 2006-03-17 00:35:28:
Logged In: YES 
user_id=75003

:P

Ok. I will use the modern option based syntax of tests for
these test. Because of the better separation of setup and
finalization from actual test body.

dgp added on 2006-03-17 00:23:12:
Logged In: YES 
user_id=80530

sorry, it's been 3 years;
I don't remember.

Make whatever changes make
sense to you, and close when
you're satisfied.

andreas_kupries added on 2006-03-17 00:19:43:
Logged In: YES 
user_id=75003

The only test using the |cat seems to be io-43.2 (8.4
branch, and HEAD as well).

Interesting. The test uses channels f2, f3, and their setup
happens before io-43.1, in regular Tcl code. This code is
constrained by 'openpipe', whereas the test is constrained
by {stdio, unixExecs, fileevent}. The test is not
constrained with "openpipe", but I guess that it should be.

I did not see the close for the channels, not near 43.* ...
Ah, the tests 44.[1234] also use these channels, and the
close happens after non-user 44.5. These tests are also not
constrained by "openpipe".

So, the exact request is to replicate the open| code in all
the tests using the channels, as listed above, as well as
the close| statements, and to constrain the tests with an
additional "openpipe", right ?

Attachments: