| Ticket UUID: | 667456 | |||
| Title: | replace regexp with string commands | |||
| Type: | RFE | Version: | None | |
| Submitter: | davidw | Created on: | 2003-01-13 23:01:42 | |
| Subsystem: | 38. Init - Library - Autoload | Assigned To: | dgp | |
| Priority: | 2 | Severity: | ||
| Status: | Closed | Last Modified: | 2003-03-20 05:10:21 | |
| Resolution: | Accepted | Closed By: | dgp | |
| Closed on: | 2003-03-19 22:10:21 | |||
| Description: |
I have gone through and replaced regexp commands with their equivalent string commands. Patch attached. | |||
| User Comments: |
dgp added on 2003-03-20 05:10:21:
Logged In: YES user_id=80530 committed to HEAD rejected changes to http 1.0 because that package is only distributed to support Tcl 7 interps. added patchlevel jumps to other packages. Had to fix several problems with the patch. In the future, please `make test` before submitting the patch here. davidw added on 2003-01-24 04:34:33: Logged In: YES user_id=240 Fair enough. My reasons for taking the time to do this were: 1) It's faster. Maybe none of these cases in the patch will benefit from that, though. It also doesn't take up space in the regexp cache. 2) I think it's good style, because it encourages people to use the right tool for the job. Rather than drop the priority and just leave it alone, why not decide on it on the tcl-core list? If people do want to do it, the patch is going to go in better now rather than later. If people don't want to see it happen, I'm certainly not going to be offended, and best to decide and be done with it. dgp added on 2003-01-24 04:10:44: Logged In: YES user_id=80530 seems like it's fine to make this change, but it's also fine to leave things as they are. [regexp] isn't going away. On the general principle of "If it ain't broke...", I'm inclined to leave this alone, unless there's some reason for doing this I don't perceive. For now, I'll just drop the priority. davidw added on 2003-01-14 14:01:33: File Added - 39631: regexp.diff Logged In: YES user_id=240 Sorry, don't know why there weren't any files. Feel free to reassign this and the regsub request to a better heading. dgp added on 2003-01-14 13:15:50: Logged In: YES user_id=80530 no patch attached. | |||
Attachments:
- regexp.diff [download] added by davidw on 2003-01-14 14:01:33. [details]