Ticket UUID: | 653511 | |||
Title: | Deallocate env vars when finalizing | |||
Type: | Patch | Version: | None | |
Submitter: | mdejong | Created on: | 2002-12-13 23:25:29 | |
Subsystem: | 08. Environment Variables | Assigned To: | hobbs | |
Priority: | 5 Medium | Severity: | ||
Status: | Open | Last Modified: | 2003-02-19 03:05:36 | |
Resolution: | None | Closed By: | ||
Closed on: | ||||
Description: |
Here is a patch that calls ckfree() in TclFinalizeEnvironment for env vars that Tcl has allocated. I ran into this while trying to plug memory leaks in the core so that I could figure out if my extension was leaking memory. This patch will also reset the original environ pointer in TclFinalizeEnvironment. While this fixes the memory leak, I wanted someone else to review it to so they could look at the environ string issue with a fresh eye. My question is, should Tcl reset the original state after it is unloaded or should it leave the possibly modified env array the way it was and leak this memory? If leaking memory is the way to go, would it make sense to allocate them with malloc so that they do not show up as leaked memory with TCL_MEM_DEBUG? | |||
User Comments: |
mdejong added on 2003-02-19 03:05:36:
File Added - 42806: env.patch2 Logged In: YES user_id=90858 How very strange. I could have sworn I added the patch before. hobbs added on 2003-02-19 02:53:54: Logged In: YES user_id=72656 no patch? |
Attachments:
- env.patch2 [download] added by mdejong on 2003-02-19 03:05:36. [details]