Tcl Source Code

View Ticket
Login
Ticket UUID: 602566
Title: should use 'exists' instead of 'exist'
Type: Bug Version: obsolete: 8.4.1
Submitter: davidw Created on: 2002-08-30 18:46:18
Subsystem: 69. Other Assigned To: dkf
Priority: 2 Severity:
Status: Closed Last Modified: 2002-10-04 15:26:45
Resolution: Fixed Closed By: dkf
    Closed on: 2002-10-04 08:26:45
Description:
This is a very low priority nitpick, but I noticed that
info exist is used in place of info exists in several
places.  'exists' is what's documented, and Tcl should
use that, for consistency's sake.

cd ~/download/tcl/
find . -type f -print0 | xargs -0 -e grep -n -e 'info
exist '
./library/http/http.tcl:174:
if {[info exist state(-command)]} {
./library/http/http.tcl:559:    if {[info exist state]} {
./library/init.tcl:43:    if {[info exist
env(TCLLIBPATH)]} {
./library/init.tcl:63:    if {[info exist ::tcl_pkgPath]} {
./library/outoftheway_init.tcl:42:    if {[info exist
env(TCLLIBPATH)]} {
./library/outoftheway_init.tcl:60:if {[info exist
tcl_pkgPath]} {
./tests/autoMkindex.test:107:if {[info exist
auto_mkindex_parser::initCommands]} {
./tests/autoMkindex.test:112:    if {[info exist
saveCommands]} {
./tests/autoMkindex.test:114:    } elseif {[info exist
auto_mkindex_parser::initCommands]} {
./tests/autoMkindex.test:347:if {[info exist
saveCommands]} {
./tests/binary.test:609:    list [binary scan abc a5
arg1] [info exist arg1]
./tests/binary.test:648:    list [binary scan abc A5
arg1] [info exist arg1]
./tests/env.test:201:    set result [info exist
env(THIS_SHOULDNT_EXIST)]
./tests/env.test:218:    # The info exist command
should be in synch with the env array.
./tests/http.test:23:    if {[info exist http2]} {
./tests/http.test:496:if {[info exist removeHttpd]} {
./tests/httpd:78:
if {![info exist data(length_orig)]} {
./tests/httpd:106:
    if {![info exist data(mime,content-length)]} {
./tests/httpold.test:22:    if {[info exist httpold]} {
./tools/man2help2.tcl:871:    if {[info exist bitmap]} {

This should be easy to fix with a script.
User Comments: dkf added on 2002-10-04 15:26:45:
Logged In: YES 
user_id=79902

Picky picky picky.  (Fixed; thanks for bringing this to our
attention.)

davidw added on 2002-10-04 01:25:50:

File Added - 32327: latest.diff

Logged In: YES 
user_id=240

Here's a patch

davidw added on 2002-10-04 01:21:15:
Logged In: YES 
user_id=240

You forgot 'file exist[^s]'.  Thankyou.

Attachments: