Tcl Source Code

Running make winhelp under cygwin produces an error 
that wasn't present in 8.4a3. This is due to a coding 
error recently introduced in tools/win2help.tcl.

Line 121 should be changed from

set baseName [lindex $argv [incr arg]]

to
set baseName [lindex $argv $arg]

So the correct version and base name are passed into 
from the makefile.

Logged In: YES 
user_id=7549

is this fixed?

Logged In: YES 
user_id=7549

I applied the first issue and committed to HEAD:

***************
*** 116,123 ****
  
  if {![string compare [lindex $argv $arg] "-bitmap"]} {
      set bitmap [lindex $argv [incr arg]]
  }
! set baseName [lindex $argv [incr arg]]
  set version [lindex $argv [incr arg]]
  set files {}
  foreach i [lrange $argv [incr arg] end] {
--- 116,124 ----
  
  if {![string compare [lindex $argv $arg] "-bitmap"]} {
      set bitmap [lindex $argv [incr arg]]
+     incr arg
  }
! set baseName [lindex $argv $arg]
  set version [lindex $argv [incr arg]]
  set files {}
  foreach i [lrange $argv [incr arg] end] {

script directory was acting for me as the build directory.  
Maybe we should add it as a commandline arg?

Logged In: YES 
user_id=7549

>In addition, line 60 same file
>Change
>set file [open [file join [file dirname [info script]] \
>basename.rtf] w]
>To
>set file [open $basename.rtf w]
>
>Since the rtf file is expected to be in the tk/win folder (i.e. 
>local) per the help project file created eariler.

That part's trouble as makefile.vc copies the scripts to a build 
directory.  Prior, man2tcl.exe had to be built in the tools 
directory which is what I'm trying to avoid by using it's direct 
location.

Logged In: YES 
user_id=7549

This'll do the first issue.

Index: man2help.tcl
=============================================
======================
RCS file: /cvsroot/tcl/tcl/tools/man2help.tcl,v
retrieving revision 1.12
diff -c -r1.12 man2help.tcl
*** man2help.tcl8 May 2002 04:21:07 -00001.12
--- man2help.tcl8 Aug 2002 08:04:43 -0000
***************
*** 116,123 ****
  
  if {![string compare [lindex $argv $arg] "-bitmap"]} {
      set bitmap [lindex $argv [incr arg]]
  }
! set baseName [lindex $argv [incr arg]]
  set version [lindex $argv [incr arg]]
  set files {}
  foreach i [lrange $argv [incr arg] end] {
--- 116,124 ----
  
  if {![string compare [lindex $argv $arg] "-bitmap"]} {
      set bitmap [lindex $argv [incr arg]]
+     incr arg
  }
! set baseName [lindex $argv $arg]
  set version [lindex $argv [incr arg]]
  set files {}
  foreach i [lrange $argv [incr arg] end] {

Logged In: YES 
user_id=72656

Tom is complaining about changes to tools/man2help.tcl, 
which you have most recently been tinkering with, not the 
cygwin make targets that call it.

Logged In: YES 
user_id=7549

Jeff is incorrect.  I am not the maintainer of the cygwin 
builds.  The attached patch now breaks makefile.vc

So whom is right?  I'll investigate as my free-time allows.

Logged In: YES 
user_id=72656

These are now updated by davygrvy.

File Added - 25635: man2help.tcl.patch

Logged In: YES 
user_id=95266

And finally, creating the .cnt file should also take place in the 
local folder. The bottom line is help is built from the tk folder, 
not tcl (since tk is part of it). Therefore, you can't create 
output files in the tcl folder unless you change other things 
like makefiles and help workship files that reference them. 
These changes make the build process work like it did in 
8.4a4 and earlier. See final patch attachment.

Logged In: YES 
user_id=95266

In addition, line 60 same file
Change
set file [open [file join [file dirname [info script]] \
basename.rtf] w]
To
set file [open $basename.rtf w]

Since the rtf file is expected to be in the tk/win folder (i.e. 
local) per the help project file created eariler.