Tcl Source Code

View Ticket
Login
Ticket UUID: 563122
Title: EOVERFLOW not defined on BSD/OS
Type: Bug Version: obsolete: 8.4a5
Submitter: jcw Created on: 2002-05-31 22:48:46
Subsystem: 37. File System Assigned To: dkf
Priority: 7 High Severity:
Status: Closed Last Modified: 2002-06-07 15:51:24
Resolution: Fixed Closed By: dkf
    Closed on: 2002-06-07 08:51:24
Description:
There are build problems, all seem to be related to the 
change to 64-bit files - with logic to generate an overflow.

The problem is that EOVERFLOW is not defined on 
BSD/OS.  I worked around it by copying logic from 
generic/tclIOUtil.c ... see atached patch.  This lets Tcl 
build, presumably as intended.
User Comments: dkf added on 2002-06-06 20:26:25:
Logged In: YES 
user_id=79902

I do not like the way it is done in the patch; better to
define EOVERFLOW for ourselves (if not previously defined)
in tclUnixPort.h

davygrvy added on 2002-06-05 17:06:23:

File Added - 24428: patch.txt

Logged In: YES 
user_id=7549

As per your instructions and JCW's patch run through an 
<EOL> fixer (\r made to \n) and used for reference, I present 
this patch.

dkf added on 2002-06-05 15:18:09:
Logged In: YES 
user_id=79902

I've already worked out how to fix this; the appropriate
code (of no EOVERFLOW, try EFBIG, and if no EFBIG, try
EINVAL as a sort of generic error because I've no idea what
error code to use in that case anyway) is already written in
the Windows portability header.  I'll copy it across soon
unless I can decode the patch and it contains a better
solution...

davygrvy added on 2002-06-05 05:13:07:
Logged In: YES 
user_id=7549

reassigning to donal.

The diff is unreadable for me.  It doesn't have any newlines.  
Jean-Claude, could resend it with a .txt extension so it can 
get tagged a MIME type?

jcw added on 2002-06-01 05:53:06:
Logged In: YES 
user_id=1983

Forgot to attach a sample of the compile errors I got.
Btw, this is probably an issue for DKF, not Vincent...


gcc -pipe -c -O -Wall -Wconversion -Wno-implicit-int 
-export-dynamic -fPIC -I../
../../src/tcl/unix/../generic -I../../../src/tcl/unix 
-DHAVE_UNISTD_H=1 -DHAVE_L
IMITS_H=1 -DTCL_WIDE_INT_TYPE=long\ long 
-DHAVE_GETCWD=1 -DHAVE_OPENDIR=1 -DHAVE
_STRSTR=1 -DHAVE_STRTOL=1 -DHAVE_TMPNAM=1 
-DHAVE_WAITPID=1 -DHAVE_UNISTD_H=1 -DH
AVE_SYS_PARAM_H=1 -DUSE_TERMIOS=1 
-DHAVE_SYS_TIME_H=1 -DTIME_WITH_SYS_TIME=1 -DH
AVE_TM_ZONE=1 -DHAVE_GMTIME_R=1 
-DHAVE_LOCALTIME_R=1 -DHAVE_TM_GMTOFF=1 
-DHAVE_S
T_BLKSIZE=1 -DSTDC_HEADERS=1 -DNEED_MATHERR=1 
-DHAVE_SIGNED_CHAR=1 -DSTATIC_BUIL
D=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_SYS_FILIO_H=1      
   -DTCL_SHLIB_EXT=\".so\" ..
/../../src/tcl/unix/../generic/tclIO.c
../../../src/tcl/unix/../generic/tclIO.c: In function `Tcl_Seek':
../../../src/tcl/unix/../generic/tclIO.c:5456: `EOVERFLOW' 
undeclared (first use
 in this function)
../../../src/tcl/unix/../generic/tclIO.c:5456: (Each undeclared 
identifier is re
ported only once
../../../src/tcl/unix/../generic/tclIO.c:5456: for each function it 
appears in.)
gmake: *** [tclIO.o] Error 1

jcw added on 2002-06-01 05:48:46:

File Added - 24169: diff

Attachments: