| Ticket UUID: | 561305 | |||
| Title: | winsock2.h has function typedefs, let's use them. | |||
| Type: | Patch | Version: | None | |
| Submitter: | davygrvy | Created on: | 2002-05-28 00:37:32 | |
| Subsystem: | 25. Channel System | Assigned To: | andreas_kupries | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2002-11-27 09:30:50 | |
| Resolution: | Accepted | Closed By: | davygrvy | |
| Closed on: | 2002-11-27 02:30:50 | |||
| Description: |
winsock2.h provides function typedefs, as well as, prototypes. Let's use the header file provided typedefs in place of our own. This allows the source to be more readable. The patch isn't complete, as my uneditted diff includes at least a dozen catagories of enhancements. We might consider exporting the function table for extensions. I know I'd use it, if it was exported. | |||
| User Comments: |
davygrvy added on 2002-11-27 09:30:50:
Logged In: YES user_id=7549 committed to HEAD davygrvy added on 2002-08-08 16:58:27: Logged In: YES
user_id=7549
***************
*** 502,508 ****
{
int enabled;
Tcl_MutexLock(&socketMutex);
! enabled = (winSock.hInstance != NULL);
Tcl_MutexUnlock(&socketMutex);
return enabled;
}
--- 479,485 ----
{
int enabled;
Tcl_MutexLock(&socketMutex);
! enabled = (winSock.hModule != NULL);
Tcl_MutexUnlock(&socketMutex);
return enabled;
}
hobbs added on 2002-08-08 15:10:30: Logged In: YES user_id=72656 This patch appears incomplete - it doesn't take into account SocketsEnabled, which is called all over tclWinSock.c, but this breaks it ... :(. davygrvy added on 2002-05-28 07:37:32: File Added - 23848: patch.txt | |||
Attachments:
- patch.txt [download] added by davygrvy on 2002-05-28 07:37:32. [details]