| Ticket UUID: | 544546 | |||
| Title: | io.test namespace patch | |||
| Type: | Patch | Version: | None | |
| Submitter: | dgp | Created on: | 2002-04-16 07:18:46 | |
| Subsystem: | 25. Channel System | Assigned To: | dgp | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2002-04-17 05:35:31 | |
| Resolution: | Accepted | Closed By: | dgp | |
| Closed on: | 2002-04-16 22:35:31 | |||
| Description: |
Here's a patch that puts the whole operation of the io.test test file into its own namespace for more reliable cleanup. | |||
| User Comments: |
dgp added on 2002-04-17 05:35:31:
Logged In: YES user_id=80530 committed to HEAD (8.4a5) andreas_kupries added on 2002-04-17 05:11:47: Logged In: YES user_id=75003 Given that tcltest 2 will be distributed with 8.4 final we truly don't have to care about these dependencies. Well, except for using the correct require statement. I don't see tcltest 1 support as important, not for the tcl testsuite itself. It comes with tcl and therefore tcl can make use of its newest features without fear. dgp added on 2002-04-17 05:06:55: Logged In: YES user_id=80530 Ack! You're right, I introduced tcltest 2 dependencies. Since you don't mind, I'm going to keep them because 1) They make the code simpler, and easier to read. 2) I don't want to go through all that file again so soon. I'll add the requirement to the [package require] before commit. If tcltest 1 support is important, it isn't hard to hack in replacements for the [interpreter] and [testConstraint] commands. andreas_kupries added on 2002-04-17 04:45:08: Logged In: YES
user_id=75003
The patch applies cleany and does not create additional
errors when executing the testsuite of tcl. I accept it.
The only misgivings I had while looking at it was that it
actually contains two logically different changes:
(1) The move into the namespace
(2) Usage of newer tcltest features to make the
code clearer. Example:
- set f [open "|[list $::tcltest::tcltest cat]" w+]
+ set f [open "|[list [interpreter] cat]" w+]
I accept both. Back to the submitter for actual integration.
dgp added on 2002-04-16 14:18:46: File Added - 21270: iotest.patch | |||
Attachments:
- iotest.patch [download] added by dgp on 2002-04-16 14:18:46. [details]