Tcl Source Code

View Ticket
Login
Ticket UUID: 535952
Title: CallTraces refactor
Type: Patch Version: None
Submitter: dgp Created on: 2002-03-27 22:35:34
Subsystem: 07. Variables Assigned To: dgp
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2002-03-29 07:03:49
Resolution: Accepted Closed By: dgp
    Closed on: 2002-03-29 00:03:49
Description:
Every call to CallTraces in tclVar.c is accompanied
by nearly the same boilerplate code for handling the
variety of return types.  This patch factors all 
that common code into CallTraces itself.
User Comments: dgp added on 2002-03-29 07:03:49:
Logged In: YES 
user_id=80530

committed corrected patch to HEAD (8.4a5)

msofer added on 2002-03-29 05:18:39:
Logged In: YES 
user_id=148712

Patch is fine, with two minor caveats:
  - compiler reports "unused variable msg" at line 3090
  - the comment on line 4442 (re leaveErrMsg) does not seem
appropriate

I will not be able to modify or commit this till next
tuesday; Don, you're welcome to proceed before then.

dgp added on 2002-03-28 05:35:34:

File Added - 20157: calltraces.patch

Attachments: