Tcl Source Code

View Ticket
Login
Ticket UUID: 534903
Title: threadReap does not belong in tcltest
Type: Bug Version: obsolete: 8.4a5
Submitter: dgp Created on: 2002-03-25 22:27:29
Subsystem: 34. tcltest Package Assigned To: dgp
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2002-06-08 03:30:42
Resolution: Fixed Closed By: dgp
    Closed on: 2002-06-07 20:30:42
Description:
tcltest 2 provides the command [tcltest::threadReap].

However, this command serves no function in providing
the functionality of a generic testing harness.
Rather, it is a command that would be useful to
register as a callback within a generic testing
harness by a particular test suite that was testing
the Thread extension, or the threading capabilities
of thread-enabled Tcl.

Looking at the internals makes this clear.  Basically,
it is

 if {we're testing the Thread package} {
   # do one set of things
 } elseif {we're testing thread-enabled Tcl} {
   # do some other set of things
 } else {# do nothing}

The tcltest package should stick to the foundations,
and not become a dumping ground for the special
purpose testing utility needs of other packages.
The tcltest package must provide a complete set of
callback registration facilities so that other
package can register all the special purpose utilities
they need on their own.

Same argument goes for [*locale] and most of the
constraints.
User Comments: dgp added on 2002-06-08 03:30:42:
Logged In: YES 
user_id=80530

patch applied.

dgp added on 2002-06-01 06:31:13:

File Added - 24171: ttthread.patch

Logged In: YES 
user_id=80530

Here's a patch:

[mainThread] and [threadReap] removed from documentation,
and kept in code explicitly as "tcltest 1 compatibility".

dgp added on 2002-04-26 00:37:09:
Logged In: YES 
user_id=80530

It appears that some tcltest 1 releases included
[threadReap], so it will need to stick around at
least for compatibility purposes.

We can still demote it to an undocumented, "deprecated"
state, though.

dgp added on 2002-03-26 05:35:52:
Logged In: YES 
user_id=80530

Are any projects/packages out there other than Tcl
itself calling on [tcltest::threadReap]?

It appears that tix and Tk are both going to the
trouble of defining their own versions of it, but
then do not use it.  Any other examples?

Attachments: