Ticket UUID: | 525403 | |||
Title: | Fix building of Tk with mingw 1.1 | |||
Type: | Patch | Version: | None | |
Submitter: | mdejong | Created on: | 2002-03-04 07:33:08 | |
Subsystem: | 52. Portability Support | Assigned To: | hobbs | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2002-03-07 09:23:17 | |
Resolution: | Fixed | Closed By: | mdejong | |
Closed on: | 2002-03-07 02:23:17 | |||
Description: |
This patch should not need to go into the 8.4a4 release since Tcl does not yet build with mingw 1.1. If this patch looks good, give me the ok and I can check it in after the a4 branch has been created. It should not break the VC++ build but I only tested it with mingw. | |||
User Comments: |
mdejong added on 2002-03-07 09:23:17:
Logged In: YES user_id=90858 Added to CVS on 2002-03-06. mdejong added on 2002-03-07 09:04:11: File Added - 18935: ie_default.patch2 hobbs added on 2002-03-07 08:43:17: Logged In: YES user_id=72656 I favor the comment right now. In my view, this is more of a lack on mingw's part, and is something that can likely be removed in the future. In fact, we (Tcl and Tk compilers using mingw) should be more diligent about making bug / feature request submissions to projects like mingw when we encounter these oddities. mdejong added on 2002-03-07 08:34:25: Logged In: YES user_id=90858 Yes, that would also work. Autoconf's approach of testing for problems and incompatibilities outside the code is more complex, but I think it leads to better code in the long run. The short snip of code in the autoconf test shows exactly what the problem is and where it applies. I am not saying you could not add a comment, but code can sometimes be a better description than a #define in a .c file. I have run into other parts of Tcl that suffer in this area (the Windows CHAR junk is simply a nightmare). You make the call, a simple #define with a comment or a larger autoconf test. hobbs added on 2002-03-07 06:44:14: Logged In: YES user_id=72656 does it not work to more simply do #ifndef _WIN32_IE #define _WIN32_IE 0x0300 #endif That seems like a lot of tcl.m4 magic to get one definition. mdejong added on 2002-03-06 15:20:51: File Deleted - 18772: File Added - 18865: ie_default.patch mdejong added on 2002-03-04 14:33:08: File Added - 18772: ie_default.patch |