Ticket UUID: | 510022 | |||
Title: | Win64 support | |||
Type: | Patch | Version: | None | |
Submitter: | davygrvy | Created on: | 2002-01-29 03:54:22 | |
Subsystem: | 52. Portability Support | Assigned To: | hobbs | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2008-03-13 03:36:56 | |
Resolution: | Rejected | Closed By: | davygrvy | |
Closed on: | 2008-03-12 20:36:56 | |||
Description: |
Provided is a starting place. 0% of it has been tested. I can't run Win64 here, but can run the test compiler. All type warnings have been elimitated. The most common ones involved the following: char *a = start; char *b = end; int len = (b-a); just a simple cast was added. __int64 isn't int under win64 and it's obvious from the context it won't over- run or truncate data. int len = (int) (b-a); In the Windows code, I did get a bit specific as the types are in the SDK headers: int len = (int) (ULONG_PTR) (b-a); Just so no pointer math misunderstandings happen. If b and a where Tcl_UniChar, the answer would be byte length and not char length. I might have made some errors regarding this. Watch for it :) | |||
User Comments: |
davygrvy added on 2008-03-13 03:36:56:
Logged In: YES user_id=7549 Originator: YES please ignore this big waste of time I did. davygrvy added on 2002-02-26 03:47:09: Logged In: YES user_id=7549 I have no clue, and will not follow through with this patch. I placed it here for reference only should someone wish to complete it. hobbs added on 2002-02-26 02:04:49: Logged In: YES user_id=72656 following the TIP 72 additions by DKF, how much of this needs to get fixed? davygrvy added on 2002-01-29 17:46:48: File Deleted - 16932: davygrvy added on 2002-01-29 17:46:47: File Added - 16937: patch.txt davygrvy added on 2002-01-29 17:46:45: Logged In: YES user_id=7549 ok, here's a better patch. Absolutely no warnings are generate for either win32 or win64. The quality of the patch is unknown. davygrvy added on 2002-01-29 11:27:14: File Added - 16935: diff.txt davygrvy added on 2002-01-29 11:27:13: Logged In: YES user_id=7549 delete the diff section for tclWinReg.c, it caused conflicts. Also replace the section for tclWinInit.c with this one. Would you like for me to place this in CVS as a branch? I can't follow through with it as I don't run Win64. davygrvy added on 2002-01-29 10:54:23: File Added - 16932: patch.txt |
Attachments:
- patch.txt [download] added by davygrvy on 2002-01-29 17:46:45. [details]