Ticket UUID: | 507181 | |||
Title: | suspect code in INST_{LIST,INVOKE_STK1} | |||
Type: | Bug | Version: | obsolete: 8.4a4 | |
Submitter: | dgp | Created on: | 2002-01-22 21:18:50 | |
Subsystem: | 47. Bytecode Compiler | Assigned To: | msofer | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2002-02-28 20:04:43 | |
Resolution: | Fixed | Closed By: | msofer | |
Closed on: | 2002-02-28 13:04:42 | |||
Description: |
stackTop is decremented directly, and that decrement is passed as an argument to a macro. DANGER WILL ROBINSON! Better to use the POP_OBJECT() macro defined for this purpose. Here's a patch. | |||
User Comments: |
msofer added on 2002-02-28 20:04:43:
File Added - 18564: exec2.patch msofer added on 2002-02-28 20:04:42: Logged In: YES user_id=148712 Now it did: exec2.patch committed dgp added on 2002-02-28 11:39:36: Logged In: YES user_id=80530 Did this issue get resolved? hobbs added on 2002-01-23 04:27:40: Logged In: YES user_id=72656 Note that there are many more instances of this use that Don warns against in the new LIST instructions than are accounted for in the patch. dgp added on 2002-01-23 04:21:34: File Added - 16589: exec.patch |