| Ticket UUID: | 503565 | |||
| Title: | TIP 27: tclIO.c, etc. | |||
| Type: | Patch | Version: | CONSTify | |
| Submitter: | dgp | Created on: | 2002-01-14 22:26:39 | |
| Subsystem: | 25. Channel System | Assigned To: | dgp | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2002-02-08 16:06:05 | |
| Resolution: | Accepted | Closed By: | dkf | |
| Closed on: | 2002-02-08 09:06:05 | |||
| Description: |
Here's a patch implementing TIP 27 (CONST-ification of APIs) for the file generic/tclIO.c. It includes necessary changes to docs and headers. Note that Tcl's Channel Driver API is also CONST-fied and all internal channel drivers are updated to the new interface. See also Tcl Bug 500348]. Assigned to maintainer for review. | |||
| User Comments: |
dgp added on 2002-01-16 01:10:13:
File Added - 16119: io.patch dgp added on 2002-01-16 01:10:05: Logged In: YES user_id=80530 trying again... (or just get it from CVS now). andreas_kupries added on 2002-01-16 01:02:21: Logged In: YES user_id=75003 There are no files attached right now dgp added on 2002-01-16 00:53:00: File Deleted - 16056: dgp added on 2002-01-16 00:52:59: Logged In: YES user_id=80530 Here's an updated patch addressing those points and a general documentation cleanup. Also it moves the Tcl_EolTranslation enum from tcl.h to tclInt.h because that is not used anywhere in Tcl's public interface. Committed to HEAD (8.4a4). andreas_kupries added on 2002-01-15 10:22:35: Logged In: YES user_id=75003 Clarification: The things I noted in the manpage are marginal, thus I decided that the patch is applicable. andreas_kupries added on 2002-01-15 10:20:50: Logged In: YES user_id=75003 OpenFileChnl.3: Tcl_WriteRaw, "bytePtr" is not described in the section ARGUMENTS. Same for "readPtr" of Tcl_ReadRaw. "readBuf" of Tcl_Read is described. The API changes look good. Application of patch flawless. Linux: Compilation ok. Testsuite ok (0 errors). A general question came to me while looking the patch: I noticed one place where a string is duplicated. Can we rely on the existence of "strdup" ? And if not would it be worthy to have a compat/strdup ? The patch is good. Back to submitting maintainer for application to the CVS. dgp added on 2002-01-15 05:26:53: File Added - 16056: io.patch | |||
Attachments:
- io.patch [download] added by dgp on 2002-01-16 01:10:05. [details]