Ticket UUID: | 471509 | |||
Title: | TIP 27: tclUtf.c, tclRegExp.c | |||
Type: | Patch | Version: | CONSTify | |
Submitter: | dgp | Created on: | 2001-10-15 22:00:33 | |
Subsystem: | 44. UTF-8 Strings | Assigned To: | dgp | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2002-02-08 16:06:04 | |
Resolution: | Accepted | Closed By: | dkf | |
Closed on: | 2002-02-08 09:06:04 | |||
Description: |
Here's a patch implementing TIP 27 (CONST-ification of APIs) for the files generic/tclUtf.c and generic/tclRegExp.c. It includes necessary changes to docs and headers. Note in particular that several routines previously returning (char *) now return (CONST char *) and this may be a source incompatibility for the callers as approved in TIP 27. Assigned to maintainer for review. | |||
User Comments: |
dgp added on 2002-01-17 10:46:53:
Logged In: YES user_id=80530 committed to HEAD (8.4a4) hobbs added on 2002-01-17 02:03:43: Logged In: YES user_id=72656 everything appears in order with the patch. dgp added on 2001-12-05 09:13:07: Logged In: YES user_id=80530 Jeff's back from vacation... dkf added on 2001-11-27 18:22:15: Logged In: YES user_id=79902 Looks OK to me for tclCmdMZ.c nobody added on 2001-11-27 17:15:00: Logged In: NO Looks fine to me for all areas I maintain -- Vince. dgp added on 2001-11-27 11:37:25: Logged In: YES user_id=80530 I'll correct the ChangeLog entries for both Tcl and Tk before commit. andreas_kupries added on 2001-11-27 09:24:50: Logged In: YES user_id=75003 I believe Mo brought this topic up sometime in the past. He asks us to explicitly spell out each changed file in the ChangeLog instead of writing glob pattern as that makes searching (grep, editor) for when a specific file was touched much easier. Beyond that I see no problem with the patch. Assigning to 34 maintainer for review. dgp added on 2001-11-27 01:13:04: File Deleted - 12014: dgp added on 2001-11-27 01:13:03: File Added - 13812: tip27.patch Logged In: YES user_id=80530 Here's the updated patch, ready for review and commit. The functional areas affected are: 17. Commands M-Z 24. Channel System 34. Pathname Management 38. Dynamic Loading (comments only) 41. Regexp 42. UTF-8 Strings Assigning to 24 maintainer to start the reviews. dgp added on 2001-10-20 03:43:32: Logged In: YES user_id=80530 Note this patch modifies mac/tclMacLoad.c. There is a new version of Tcl Patch 435658 in the works that will have different modifications to that file. It is expected that after Patch 435658 is integrated in its final form, there will be no further changes required to achieve the goals of this patch. After 435658 is integrated, watch this report for an updated TIP 27 patch. dgp added on 2001-10-16 05:00:37: File Added - 12014: tip27.patch |
Attachments:
- tip27.patch [download] added by dgp on 2001-11-27 01:13:03. [details]