| Ticket UUID: | 455021 | |||
| Title: | remove obsolete, private FS apis | |||
| Type: | Patch | Version: | None | |
| Submitter: | vincentdarley | Created on: | 2001-08-24 17:28:38 | |
| Subsystem: | 37. File System | Assigned To: | vincentdarley | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2001-08-30 22:49:21 | |
| Resolution: | Fixed | Closed By: | dgp | |
| Closed on: | 2001-08-30 15:49:21 | |||
| Description: |
This patch will remove all obsolete private Tcl fs APIs which are not called by any known extension. The likely candidate list is given by: Tcl(p (Access|Stat|Lstat|Chdir|CopyFile|GetCwd|ReadLink|ListV olumes|RenameFile|DeleteFile|CreateDirectory|CopyDirect ory|RemoveDirectory)|Stat|Access) (I may have missed some) but I'm currently evaluating which of these either (i) might be called internally (ii) might be called by extensions. Vince. | |||
| User Comments: |
dgp added on 2001-08-30 22:49:21:
Logged In: YES user_id=80530 The test filename-4.19 leaves behind a directory named tildetmp. vincentdarley added on 2001-08-30 16:22:46: Logged In: YES user_id=32170 These latest changes, now applied, mean most simple filesystem operations are 20-30% faster than Tcl 8.3.x. Also vfs support is now improved to the point where Tcl is happy to have entire file protocols mounted as volumes (e.g. the tclvfs extension can mount 'ftp://' as a root volume). A few small bugs have been fixed, in particular the handling of './~not_a_user' is completely consistent across both native fs and vfs. dgp added on 2001-08-30 02:14:40: Logged In: YES user_id=80530 tests pass now. vincentdarley added on 2001-08-30 01:22:33: File Deleted - 10137: File Added - 10139: fsObsRemove4.patch vincentdarley added on 2001-08-30 01:22:32: Logged In: YES user_id=32170 Added some more tests, and fixed a potential problem on Windows. vincentdarley added on 2001-08-30 00:15:22: File Deleted - 10132: File Added - 10137: fsObsRemove3.patch Logged In: YES user_id=32170 Ok, that was a silly error. Fix one problem, introduce 25 more. I believe those problems should be gone now. dgp added on 2001-08-29 23:48:14: File Added - 10134: test.log Logged In: YES user_id=80530 I applied fsObsRemove2.patch, and 'make test' reported 25 errors in fCmd.test. See test.log, attached. You can ignore the fCmd-18.10 failure -- that's normal for Linux. vincentdarley added on 2001-08-29 23:30:29: File Deleted - 10131: vincentdarley added on 2001-08-29 23:30:28: File Added - 10132: fsObsRemove2.patch vincentdarley added on 2001-08-29 23:05:12: File Deleted - 10124: File Added - 10131: fsObsRemove2.patch vincentdarley added on 2001-08-29 23:05:10: Logged In: YES user_id=32170 Updated patch. Objectifies a bit more and simplifies mac code. vincentdarley added on 2001-08-29 16:34:39: File Added - 10124: fsObsRemove.patch Logged In: YES user_id=32170 I examined BLT, TclX, TclPro, Mktclapp and Tk. Both Tclpro and Mktclapp use the access/stat/open 'hooks' and TclX uses 'TclpGetCwd'. Otherwise nothing internal is used anywhere. Patch attached (it removes a fair amount of code, which is nice). hobbs added on 2001-08-25 01:21:24: Logged In: YES user_id=72656 The primary extensions to analyse would be TclX and BLT. If those don't use it, then it is unlikely others would have poked that far. dgp added on 2001-08-25 00:57:44: Logged In: YES user_id=80530 where's the patch? | |||
Home
Timeline
Branches
Tags
Tickets
Download
Wiki